<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28101">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile: Write .xcompile to $(obj)<br><br>This file was being written to the root src directory. It is the only<br>file being written to src while all others are being written to obj. I<br>decided to leave .xcompile in the cleanup targets so any stale compies<br>will get removed on clean.<br><br>This is part of my incremental rebuild work. It saves a few targets from<br>being rebuilt.<br><br>BUG=b:112267918<br>TEST=ran emerge-grunt coreboot<br><br>Change-Id: Ia83f234447b977efa824751c9674154b77d606b0<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M Makefile<br>M Makefile.inc<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/28101/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile b/Makefile</span><br><span>index 1d4a488..ad4609d 100644</span><br><span>--- a/Makefile</span><br><span>+++ b/Makefile</span><br><span>@@ -142,18 +142,18 @@</span><br><span> </span><br><span> # in addition to the dependency below, create the file if it doesn't exist</span><br><span> # to silence stupid warnings about a file that would be generated anyway.</span><br><span style="color: hsl(0, 100%, 40%);">-$(if $(wildcard .xcompile)$(NOCOMPILE),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > .xcompile || rm -f .xcompile)))</span><br><span style="color: hsl(120, 100%, 40%);">+ $(if $(wildcard $(obj)/.xcompile)$(NOCOMPILE),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > $(obj)/.xcompile || rm -f $(obj)/.xcompile)))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-.xcompile: util/xcompile/xcompile</span><br><span style="color: hsl(120, 100%, 40%);">+$(obj)/.xcompile: util/xcompile/xcompile</span><br><span>         rm -f $@</span><br><span>     $< $(XGCCPATH) > $@.tmp</span><br><span>        \mv -f $@.tmp $@ 2> /dev/null</span><br><span>     rm -f $@.tmp</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">--include .xcompile</span><br><span style="color: hsl(120, 100%, 40%);">+-include $(obj)/.xcompile</span><br><span> </span><br><span> ifneq ($(XCOMPILE_COMPLETE),1)</span><br><span style="color: hsl(0, 100%, 40%);">-$(shell rm -f .xcompile)</span><br><span style="color: hsl(120, 100%, 40%);">+$(shell rm -f $(obj)/.xcompile)</span><br><span> $(error .xcompile deleted because it's invalid. \</span><br><span>        Restarting the build should fix that, or explain the problem)</span><br><span> endif</span><br><span>diff --git a/Makefile.inc b/Makefile.inc</span><br><span>index 7ce2360..6d60b6c 100644</span><br><span>--- a/Makefile.inc</span><br><span>+++ b/Makefile.inc</span><br><span>@@ -464,7 +464,7 @@</span><br><span> </span><br><span> #######################################################################</span><br><span> # generate build support files</span><br><span style="color: hsl(0, 100%, 40%);">-$(obj)/build.h: .xcompile</span><br><span style="color: hsl(120, 100%, 40%);">+$(obj)/build.h: $(obj)/.xcompile</span><br><span>        @printf "    GEN        build.h\n"</span><br><span>         rm -f $(obj)/build.h</span><br><span>         util/genbuild_h/genbuild_h.sh > $(obj)/build.ht</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28101">change 28101</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28101"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0 </div>
<div style="display:none"> Gerrit-Change-Number: 28101 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>