<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28075">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: sx9310 to 400kb<br><br>The spec of the sx9310 says the I2C interface can handle standard<br>(100kb/s) and fast mode (400kb/s). The current setting is using fast<br>plus (1000kb/s) so this change is reducing the speed to fast mode.<br><br>I've been using the sensors with this change for a few weeks now, though<br>I also don't recall seeing an issue prior to this change.<br><br>Change-Id: I337fc02c52565d6ec4d7bac1b3564f65238962dc<br>Signed-off-by: Matt Delco <delco@chromium.org><br>Reviewed-on: https://review.coreboot.org/28075<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 2c074e9..4fbd0ff 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -298,7 +298,7 @@</span><br><span> chip drivers/i2c/sx9310</span><br><span> register "desc" = ""Right SAR Proximity Sensor""</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"</span><br><span style="color: hsl(0, 100%, 40%);">- register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "speed" = "I2C_SPEED_FAST"</span><br><span> register "uid" = "0"</span><br><span> register "reg_prox_ctrl0" = "0x10"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span>@@ -339,7 +339,7 @@</span><br><span> chip drivers/i2c/sx9310</span><br><span> register "desc" = ""Left SAR Proximity Sensor""</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)"</span><br><span style="color: hsl(0, 100%, 40%);">- register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "speed" = "I2C_SPEED_FAST"</span><br><span> register "uid" = "1"</span><br><span> register "reg_prox_ctrl0" = "0x10"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28075">change 28075</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28075"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I337fc02c52565d6ec4d7bac1b3564f65238962dc </div>
<div style="display:none"> Gerrit-Change-Number: 28075 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Gwendal Grignou <gwendal@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Matt Delco <delco@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>