<p><a href="https://review.coreboot.org/28100">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c">File payloads/libpayload/arch/x86/exception.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c@165">Patch Set #1, Line 165:</a> <code style="font-family:monospace,monospace">       /* Handle user defined vectors */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not opposed to adding this capability in general, but I don't think it would be a good fit for the APIC timer stuff if we want to add it architecturally. In that case, I'd just hardcode an interrupt number for that and check it here directly. There can be only one exception hook, and that's currently used by GDB, so if you'd implement the APIC stuff through there you'd be breaking that. (The alternative would be to expand the hook system to a linked list.)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c@167">Patch Set #1, Line 167:</a> <code style="font-family:monospace,monospace">                die_if(!hook || !hook(vec),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this does what you want, since even if hook(vec) returns true, you'll keep running through the code below and hit the vec >= EXC_COUNT. I think you meant to return here?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28100">change 28100</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28100"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c </div>
<div style="display:none"> Gerrit-Change-Number: 28100 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 15 Aug 2018 22:26:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>