<p>Lucas Chen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28079">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">eve: Support PL1 override option<br><br>AltOS DPTF prefers MMIO to control the PL1 setting. However, MSR PL1 also<br>contributes to the decision of the max PL1 power. In the current design,<br>the lower value takes effect. In order to align MMIO and MSR settings, a<br>tdp_pl1_override option is added to override the MSR PL1 limitation.<br><br>BRANCH=eve<br>BUG=b:73133864<br>TEST=1. Write PL1 override setting in devicetree.cb<br>     2. Verify the MSR PL1 limitation is set from TAT.<br><br>Change-Id: I35b8747ad3ee4c68c30d49a9436aa319360bab9b<br>Signed-off-by: Lucas Chen <lucas.chen@quanta.corp-partner.google.com><br>---<br>M src/soc/intel/skylake/chip.h<br>M src/soc/intel/skylake/cpu.c<br>2 files changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/28079/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h</span><br><span>index a147d92..8cef686 100644</span><br><span>--- a/src/soc/intel/skylake/chip.h</span><br><span>+++ b/src/soc/intel/skylake/chip.h</span><br><span>@@ -99,6 +99,8 @@</span><br><span> </span><br><span>        /* PL2 Override value in Watts */</span><br><span>    u32 tdp_pl2_override;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* PL1 Override value in Watts */</span><br><span style="color: hsl(120, 100%, 40%);">+     u32 tdp_pl1_override;</span><br><span> </span><br><span>    /* SysPL2 Value in Watts */</span><br><span>  u32 tdp_psyspl2;</span><br><span>diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c</span><br><span>index 5535ec6..417c4bc 100644</span><br><span>--- a/src/soc/intel/skylake/cpu.c</span><br><span>+++ b/src/soc/intel/skylake/cpu.c</span><br><span>@@ -117,7 +117,7 @@</span><br><span>      msr_t msr = rdmsr(MSR_PLATFORM_INFO);</span><br><span>        msr_t limit;</span><br><span>         unsigned int power_unit;</span><br><span style="color: hsl(0, 100%, 40%);">-        unsigned int tdp, min_power, max_power, max_time, tdp_pl2;</span><br><span style="color: hsl(120, 100%, 40%);">+    unsigned int tdp, min_power, max_power, max_time, tdp_pl2, tdp_pl1;</span><br><span>  u8 power_limit_1_val;</span><br><span>        struct device *dev = SA_DEV_ROOT;</span><br><span>    config_t *conf = dev->chip_info;</span><br><span>@@ -154,7 +154,9 @@</span><br><span> </span><br><span>        /* Set long term power limit to TDP */</span><br><span>       limit.lo = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-   limit.lo |= tdp & PKG_POWER_LIMIT_MASK;</span><br><span style="color: hsl(120, 100%, 40%);">+   tdp_pl1 = ((conf->tdp_pl1_override == 0) ?</span><br><span style="color: hsl(120, 100%, 40%);">+         tdp : (conf->tdp_pl1_override * power_unit));</span><br><span style="color: hsl(120, 100%, 40%);">+      limit.lo |= (tdp_pl1 & PKG_POWER_LIMIT_MASK);</span><br><span> </span><br><span>        /* Set PL1 Pkg Power clamp bit */</span><br><span>    limit.lo |= PKG_POWER_LIMIT_CLAMP;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28079">change 28079</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28079"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I35b8747ad3ee4c68c30d49a9436aa319360bab9b </div>
<div style="display:none"> Gerrit-Change-Number: 28079 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lucas Chen <lucas.chen@quanta.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Wei Shun Chang <wei.shun.chang@intel.com> </div>