<p>Kevin Chiu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28084">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/grunt: Remove BayHub EMMC driving strength override<br><br>Side effect was observed that after override BayHub EMMC<br>driving strength to the max, EMMC CLK will be reduced to<br>51.x Mhz from 200 Mhz.<br><br>This will cause OS installation fail on Samsung EMMC sku.<br><br>BUG=b:111964336<br>BRANCH=master<br>TEST=emerge-grunt coreboot<br>Change-Id: I848ab0cae474b15fbc4264c8ade63d5c6b4e489d<br>Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/mainboard.c<br>1 file changed, 0 insertions(+), 25 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/28084/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c</span><br><span>index b1bd492..cf38b99 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c</span><br><span>@@ -17,8 +17,6 @@</span><br><span> #include <baseboard/variants.h></span><br><span> #include <gpio.h></span><br><span> #include <variant/gpio.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <drivers/generic/bayhub/bh720.h></span><br><span> </span><br><span> uint8_t variant_board_sku(void)</span><br><span> {</span><br><span>@@ -37,26 +35,3 @@</span><br><span>    gpio_set(GPIO_133, 0);</span><br><span> }</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void bh720_driving_strength(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-   u32 sdbar;</span><br><span style="color: hsl(0, 100%, 40%);">-      u32 bh720_pcr_data;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     sdbar = pci_read_config32(dev, PCI_BASE_ADDRESS_1);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     /* Enable Memory Access Function */</span><br><span style="color: hsl(0, 100%, 40%);">-     write32((void *)(sdbar + BH720_MEM_ACCESS_EN), 0x40000000);</span><br><span style="color: hsl(0, 100%, 40%);">-     write32((void *)(sdbar + BH720_MEM_RW_DATA), 0x80000000);</span><br><span style="color: hsl(0, 100%, 40%);">-       write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x800000D0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        /* Read current EMMC 1.8V CLK/DATA,CMD driving strength */</span><br><span style="color: hsl(0, 100%, 40%);">-      write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x40000304);</span><br><span style="color: hsl(0, 100%, 40%);">-        bh720_pcr_data = read32((void *)(sdbar + BH720_MEM_RW_DATA));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   /* set EMMC 1.8V CLK/DATA,CMD the max level */</span><br><span style="color: hsl(0, 100%, 40%);">-  write32((void *)(sdbar + BH720_MEM_RW_DATA),</span><br><span style="color: hsl(0, 100%, 40%);">-            bh720_pcr_data | (BH720_PCR_CLK_DRV_MAX << 4) |</span><br><span style="color: hsl(0, 100%, 40%);">-           (BH720_PCR_DATA_CMD_DRV_MAX << 1));</span><br><span style="color: hsl(0, 100%, 40%);">-       write32((void *)(sdbar + BH720_MEM_RW_ADR), 0x80000304);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28084">change 28084</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28084"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I848ab0cae474b15fbc4264c8ade63d5c6b4e489d </div>
<div style="display:none"> Gerrit-Change-Number: 28084 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com> </div>