<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28081">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vendorcode/amd/pi/00670F00: Remove functions that use LibAmdMemRMW()<br><br>The functions that use LibAmdMemRMW() are not used by coreboot and can be<br>safely removed in preparation to remove LibAmdMemRMW() itself. The<br>functions to be removed are: ProgramFchAcpiMmioTbl() and GetEfuseStatus(),<br>both from vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c.<br><br>BUG=b:112541697<br>TEST=Build grunt and gardenia<br><br>Change-Id: Ib935b1797c4bf8b504fdda6f676fca369169a7f1<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchDef.h<br>M src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c<br>2 files changed, 0 insertions(+), 65 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/28081/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchDef.h b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchDef.h</span><br><span>index 00247f4..3f4bccf 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchDef.h</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchDef.h</span><br><span>@@ -57,7 +57,6 @@</span><br><span> VOID WritePci (IN UINT32 Address, IN UINT8 OpFlag, IN VOID *Value, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID RwPci (IN UINT32 Address, IN UINT8 OpFlag, IN UINT32 Mask, IN UINT32 Data, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID ProgramPciByteTable (IN REG8_MASK* pPciByteTable, IN UINT16 dwTableSize, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">-VOID ProgramFchAcpiMmioTbl (IN ACPI_REG_WRITE *pAcpiTbl, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID ProgramFchSciMapTbl (IN SCI_MAP_CONTROL *pSciMapTbl, IN FCH_RESET_DATA_BLOCK *FchResetDataBlock);</span><br><span> VOID ProgramFchGpioTbl (IN GPIO_CONTROL *pGpioTbl);</span><br><span> VOID ProgramFchSataPhyTbl (IN SATA_PHY_CONTROL *pSataPhyTbl, IN FCH_RESET_DATA_BLOCK *FchResetDataBlock);</span><br><span>@@ -343,7 +342,6 @@</span><br><span> VOID FchPciReset (IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID OutPort80 (IN UINT32 pcode, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID OutPort1080 (IN UINT32 pcode, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">-VOID GetEfuseStatus (IN VOID* Value, IN AMD_CONFIG_PARAMS *StdHeader);</span><br><span> VOID TurnOffCG2 (OUT VOID);</span><br><span> VOID BackUpCG2 (OUT VOID);</span><br><span> VOID FchCopyMem (IN VOID* pDest, IN VOID* pSource, IN UINTN Length);</span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>index c1b14f5..ae02aec 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Proc/Fch/Common/FchPeLib.c</span><br><span>@@ -101,42 +101,6 @@</span><br><span> </span><br><span> /*----------------------------------------------------------------------------------------*/</span><br><span> /**</span><br><span style="color: hsl(0, 100%, 40%);">- * ProgramFchAcpiMmioTbl - Program FCH ACPI MMIO register by table (8 bits data)</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * @param[in] pAcpiTbl - Table data pointer</span><br><span style="color: hsl(0, 100%, 40%);">- * @param[in] StdHeader</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-VOID</span><br><span style="color: hsl(0, 100%, 40%);">-ProgramFchAcpiMmioTbl (</span><br><span style="color: hsl(0, 100%, 40%);">- IN ACPI_REG_WRITE *pAcpiTbl,</span><br><span style="color: hsl(0, 100%, 40%);">- IN AMD_CONFIG_PARAMS *StdHeader</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- UINT8 i;</span><br><span style="color: hsl(0, 100%, 40%);">- UINT8 Or8;</span><br><span style="color: hsl(0, 100%, 40%);">- UINT8 Mask8;</span><br><span style="color: hsl(0, 100%, 40%);">- UINT32 ddtempVar;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (pAcpiTbl != NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">- if ((pAcpiTbl->MmioReg == 0) && (pAcpiTbl->MmioBase == 0) && (pAcpiTbl->DataAndMask == 0xB0) && (pAcpiTbl->DataOrMask == 0xAC)) {</span><br><span style="color: hsl(0, 100%, 40%);">- // Signature Checking</span><br><span style="color: hsl(0, 100%, 40%);">- pAcpiTbl++;</span><br><span style="color: hsl(0, 100%, 40%);">- for ( i = 1; pAcpiTbl->MmioBase < 0x1D; i++ ) {</span><br><span style="color: hsl(0, 100%, 40%);">- ddtempVar = ACPI_MMIO_BASE | (pAcpiTbl->MmioBase) << 8 | pAcpiTbl->MmioReg;</span><br><span style="color: hsl(0, 100%, 40%);">- Or8 = pAcpiTbl->DataOrMask;</span><br><span style="color: hsl(0, 100%, 40%);">- Mask8 = ~pAcpiTbl->DataAndMask;</span><br><span style="color: hsl(0, 100%, 40%);">- LibAmdMemRMW (AccessWidth8, (UINT64) ddtempVar, &Or8, &Mask8, StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">- pAcpiTbl++;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*----------------------------------------------------------------------------------------*/</span><br><span style="color: hsl(0, 100%, 40%);">-/**</span><br><span> * ProgramFchSciMapTbl - Program FCH SCI Map table (8 bits data)</span><br><span> *</span><br><span> *</span><br><span>@@ -263,33 +227,6 @@</span><br><span> }</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)</span><br><span style="color: hsl(0, 100%, 40%);">-/**</span><br><span style="color: hsl(0, 100%, 40%);">- * GetEfuseStatue - Get Efuse status</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * @param[in] Value - Return Chip strap status</span><br><span style="color: hsl(0, 100%, 40%);">- * @param[in] StdHeader</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-VOID</span><br><span style="color: hsl(0, 100%, 40%);">-GetEfuseStatus (</span><br><span style="color: hsl(0, 100%, 40%);">- IN VOID *Value,</span><br><span style="color: hsl(0, 100%, 40%);">- IN AMD_CONFIG_PARAMS *StdHeader</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- UINT8 Or8;</span><br><span style="color: hsl(0, 100%, 40%);">- UINT8 Mask8;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Or8 = BIT5;</span><br><span style="color: hsl(0, 100%, 40%);">- Mask8 = BIT5;</span><br><span style="color: hsl(0, 100%, 40%);">- LibAmdMemRMW (AccessWidth8, (UINT64) (ACPI_MMIO_BASE + PMIO_BASE + FCH_PMIOA_REGC8), &Or8, &Mask8, StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">- LibAmdMemWrite (AccessWidth8, (UINT64) (ACPI_MMIO_BASE + PMIO_BASE + FCH_PMIOA_REGD8), Value, StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">- LibAmdMemRead (AccessWidth8, (UINT64) (ACPI_MMIO_BASE + PMIO_BASE + FCH_PMIOA_REGD8 + 1), Value, StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">- Or8 = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- Mask8 = BIT5;</span><br><span style="color: hsl(0, 100%, 40%);">- LibAmdMemRMW (AccessWidth8, (UINT64) (ACPI_MMIO_BASE + PMIO_BASE + FCH_PMIOA_REGC8), &Or8, &Mask8, StdHeader);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*----------------------------------------------------------------------------------------*/</span><br><span> /**</span><br><span> * SbSleepTrapControl - SB Sleep Trap Control</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28081">change 28081</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28081"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib935b1797c4bf8b504fdda6f676fca369169a7f1 </div>
<div style="display:none"> Gerrit-Change-Number: 28081 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>