<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28057">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/common: Add function to set BILD bit in RTC<br><br>Add a function to set the Bios Interface Lock Down bit (bit 31)<br>in RTC Configuration register (0x3400). This bit when set prevents<br>the top swap enable bit (bit 0) in the RTC BUC register (0x3414)<br>from being changed.<br><br>Change-Id: Iacaeeb0d6cabcf0c2c46a58948457ab832351476<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/soc/intel/common/block/include/intelblocks/rtc.h<br>M src/soc/intel/common/block/rtc/rtc.c<br>2 files changed, 12 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/28057/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/include/intelblocks/rtc.h b/src/soc/intel/common/block/include/intelblocks/rtc.h</span><br><span>index 56cfb2e..0faf0b0 100644</span><br><span>--- a/src/soc/intel/common/block/include/intelblocks/rtc.h</span><br><span>+++ b/src/soc/intel/common/block/include/intelblocks/rtc.h</span><br><span>@@ -45,4 +45,6 @@</span><br><span>  */</span><br><span> enum ts_config get_rtc_buc_top_swap_status(void);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Set RTC Configuration BILD bit. */</span><br><span style="color: hsl(120, 100%, 40%);">+void rtc_conf_set_bios_interface_lockdown(void);</span><br><span> #endif   /* SOC_INTEL_COMMON_BLOCK_RTC_H */</span><br><span>diff --git a/src/soc/intel/common/block/rtc/rtc.c b/src/soc/intel/common/block/rtc/rtc.c</span><br><span>index b8c8849..2fe4bd9 100644</span><br><span>--- a/src/soc/intel/common/block/rtc/rtc.c</span><br><span>+++ b/src/soc/intel/common/block/rtc/rtc.c</span><br><span>@@ -27,7 +27,10 @@</span><br><span> #define PCR_RTC_CONF_RESERVED   (1 << 31)</span><br><span> /* RTC backed up control register */</span><br><span> #define PCR_RTC_BUC          0x3414</span><br><span style="color: hsl(0, 100%, 40%);">-#define PCR_RTC_BUC_TOP_SWAP      (1 << 0)</span><br><span style="color: hsl(120, 100%, 40%);">+#define  PCR_RTC_BUC_TOP_SWAP   (1 << 0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCR_RTC_CONF          0x3400</span><br><span style="color: hsl(120, 100%, 40%);">+#define  PCR_RTC_CONF_BILD      (1 << 31)</span><br><span> </span><br><span> void enable_rtc_upper_bank(void)</span><br><span> {</span><br><span>@@ -48,6 +51,12 @@</span><br><span>    cmos_init(soc_get_rtc_failed());</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void rtc_conf_set_bios_interface_lockdown(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ pcr_rmw32(PID_RTC, PCR_RTC_CONF, ~PCR_RTC_CONF_BILD,</span><br><span style="color: hsl(120, 100%, 40%);">+                                          PCR_RTC_CONF_BILD);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if IS_ENABLED(CONFIG_INTEL_HAS_TOP_SWAP)</span><br><span> void configure_rtc_buc_top_swap(enum ts_config ts_state)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28057">change 28057</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28057"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iacaeeb0d6cabcf0c2c46a58948457ab832351476 </div>
<div style="display:none"> Gerrit-Change-Number: 28057 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>