<p>Caveh Jalali would like caveh jalali to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/28072">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "mb/google/poppy/variants/atlas: enable camera power and release reset"<br><br>This reverts commit 1fdb76945a9d06bbff37dee9da69e13a86c933f4.<br><br>Camera power is now handled by ACPI rules - no need to force the GPIOs<br>on by default.<br><br>BUG=b:80106316<br><br>Change-Id: Ifefec320884989f106a4b09c956d3a3279a1491a<br>Signed-off-by: Caveh Jalali <caveh@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/atlas/gpio.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/28072/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>index c0ef9ef..5f1a1f5 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>@@ -175,7 +175,7 @@</span><br><span>    /* D7  : ISH_I2C1_SDA ==> SPKR_IRQ_L */</span><br><span>   PAD_CFG_GPI_APIC(GPP_D7, NONE, PLTRST),</span><br><span>      /* D8  : ISH_I2C1_SCL ==> EN_CAMERA_PWR */</span><br><span style="color: hsl(0, 100%, 40%);">-   PAD_CFG_GPO(GPP_D8, 1, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO(GPP_D8, 0, DEEP),</span><br><span>        /* D9  : ISH_SPI_CS# ==> ISH_SPI_CS_L */</span><br><span>  PAD_CFG_NF_1V8(GPP_D9, NONE, DEEP, NF1),</span><br><span>     /* D10 : ISH_SPI_CLK ==> ISH_SPI_CLK */</span><br><span>@@ -189,9 +189,9 @@</span><br><span>     /* D16 : ISH_UART0_CTS# ==> NC */</span><br><span>         PAD_CFG_NC(GPP_D16),</span><br><span>         /* D17 : DMIC_CLK1 ==> PCH_CAMERA_RESET */</span><br><span style="color: hsl(0, 100%, 40%);">-   PAD_CFG_GPO(GPP_D17, 1, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPO(GPP_D17, 0, DEEP),</span><br><span>       /* D18 : DMIC_DATA1 ==> PCH_CAMERA_CLOCK_ENABLE */</span><br><span style="color: hsl(0, 100%, 40%);">-   PAD_CFG_GPO(GPP_D18, 1, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPO(GPP_D18, 0, DEEP),</span><br><span>       /* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */</span><br><span>        PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1),</span><br><span>        /* D20 : DMIC_DATA0 ==> PCH_DMIC_DATA_IN */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28072">change 28072</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28072"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifefec320884989f106a4b09c956d3a3279a1491a </div>
<div style="display:none"> Gerrit-Change-Number: 28072 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>