<p>John Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28060">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/common/block: Fix issues found by klockwork<br><br>src/soc/intel/common/block/cpu/mp_init.c<br>  Function init_cpus: Pointer dev checked for NULL may be<br>  deferenced.<br><br>src/soc/intel/common/block/graphics/graphics.c<br>  Function graphics_get_bar: Pointer dev returned from<br>  call may be NULL and will be deferenced.<br><br>BRANCH=None<br>TEST=Built & booted Yorp board.<br><br>Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51<br>Signed-off-by: John Zhao <john.zhao@intel.com><br>---<br>M src/soc/intel/common/block/cpu/mp_init.c<br>M src/soc/intel/common/block/graphics/graphics.c<br>2 files changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28060/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>index f52709d..b233715 100644</span><br><span>--- a/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>+++ b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>@@ -134,6 +134,7 @@</span><br><span>    microcode_patch = intel_microcode_find();</span><br><span>    intel_microcode_load_unlocked(microcode_patch);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   assert(dev->link_list != NULL);</span><br><span>   soc_init_cpus(dev->link_list);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>index c6ea7e2..022cb48 100644</span><br><span>--- a/src/soc/intel/common/block/graphics/graphics.c</span><br><span>+++ b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>@@ -15,6 +15,7 @@</span><br><span>  */</span><br><span> </span><br><span> #include <compiler.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <assert.h></span><br><span> #include <console/console.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>@@ -36,6 +37,7 @@</span><br><span> {</span><br><span>        struct device *dev = SA_DEV_IGD;</span><br><span>     struct resource *gm_res;</span><br><span style="color: hsl(120, 100%, 40%);">+      assert(dev != NULL);</span><br><span> </span><br><span>     /* Check if Graphics PCI device is disabled */</span><br><span>       if (!dev->enabled)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28060">change 28060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 </div>
<div style="display:none"> Gerrit-Change-Number: 28060 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>