<p><a href="https://review.coreboot.org/28024">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/Makefile.inc">File src/mainboard/opencellular/elgon/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/Makefile.inc@35">Patch Set #5, Line 35:</a> <code style="font-family:monospace,monospace">gbcv2.dtb</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Actually it must be named sff8104-linux.dtb, see soc.c<br>I'll remove the devicetree code from ATF as we don't need it at all, and than we don't need to include it into the CBFS.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/gbcv2.dts">File src/mainboard/opencellular/elgon/gbcv2.dts:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/gbcv2.dts@195">Patch Set #5, Line 195:</a> <code style="font-family:monospace,monospace">serial@87e02a000000</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think there are only two UARTs exposed. The other entries could be removed.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/vboot.fmd">File src/mainboard/opencellular/elgon/vboot.fmd:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28024/5/src/mainboard/opencellular/elgon/vboot.fmd@2">Patch Set #5, Line 2:</a> <code style="font-family:monospace,monospace">0x63d4c0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Align to a supported flash protection range. 8 or 4 MiB.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28024">change 28024</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28024"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9b809306cc48facbade5dc63846c4532b397e0b5 </div>
<div style="display:none"> Gerrit-Change-Number: 28024 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 11 Aug 2018 07:49:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>