<p>John Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28019">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/common/block: Fix issues found by klockwork<br><br>src/soc/intel/common/block/cpu/mp_init.c<br>  Function init_cpus: Pointer dev checked for NULL may be<br>  deferenced.<br><br>src/soc/intel/common/block/graphics/graphics.c<br>  Function graphics_get_bar: Pointer dev returned from<br>  call may be NULL and will be deferenced.<br><br>BRANCH=None<br>TEST=Built & booted Yorp board.<br><br>Change-Id: Ia79d6c08c3b75dfd638a75563fb06a4916b7b218<br>Signed-off-by: John Zhao <john.zhao@intel.com><br>---<br>M 3rdparty/blobs<br>M src/soc/intel/common/block/cpu/mp_init.c<br>M src/soc/intel/common/block/graphics/graphics.c<br>3 files changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/28019/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/3rdparty/blobs b/3rdparty/blobs</span><br><span>index 372012e..c285102 160000</span><br><span>--- a/3rdparty/blobs</span><br><span>+++ b/3rdparty/blobs</span><br><span>@@ -1 +1 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Subproject commit 372012e8e1d0d01f3e77ff73b118665b41ff68b6</span><br><span style="color: hsl(120, 100%, 40%);">+Subproject commit c2851026e72dcb7b8c1d19e750c0416a6abf41ce</span><br><span>diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>index 89c95a4..64d262d 100644</span><br><span>--- a/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>+++ b/src/soc/intel/common/block/cpu/mp_init.c</span><br><span>@@ -125,14 +125,16 @@</span><br><span> {</span><br><span>  struct device *dev = dev_find_path(NULL, DEVICE_PATH_CPU_CLUSTER);</span><br><span>   assert(dev != NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+  DEVTREE_CONST struct bus *bus = dev->link_list;</span><br><span style="color: hsl(120, 100%, 40%);">+    assert(bus != NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+  </span><br><span>     if (chip_get_fsp_mp_init())</span><br><span>          return;</span><br><span> </span><br><span>  microcode_patch = intel_microcode_find();</span><br><span>    intel_microcode_load_unlocked(microcode_patch);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     soc_init_cpus(dev->link_list);</span><br><span style="color: hsl(120, 100%, 40%);">+     soc_init_cpus(bus);</span><br><span> }</span><br><span> </span><br><span> static void wrapper_x86_setup_mtrrs(void *unused)</span><br><span>diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>index c6ea7e2..022cb48 100644</span><br><span>--- a/src/soc/intel/common/block/graphics/graphics.c</span><br><span>+++ b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>@@ -15,6 +15,7 @@</span><br><span>  */</span><br><span> </span><br><span> #include <compiler.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <assert.h></span><br><span> #include <console/console.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>@@ -36,6 +37,7 @@</span><br><span> {</span><br><span>         struct device *dev = SA_DEV_IGD;</span><br><span>     struct resource *gm_res;</span><br><span style="color: hsl(120, 100%, 40%);">+      assert(dev != NULL);</span><br><span> </span><br><span>     /* Check if Graphics PCI device is disabled */</span><br><span>       if (!dev->enabled)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28019">change 28019</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28019"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia79d6c08c3b75dfd638a75563fb06a4916b7b218 </div>
<div style="display:none"> Gerrit-Change-Number: 28019 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>