<p><a href="https://review.coreboot.org/27997">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants/nocturne/mainboard.c">File src/mainboard/google/poppy/variants/nocturne/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants/nocturne/mainboard.c@23">Patch Set #1, Line 23:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">define PL2_AML       18<br>#define PL2_KBL     15<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Better to add comment about 18 Watt and 15 Watt, or just change get_pl2 to get_pl2_in_watts for easier understanding</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27997">change 27997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973 </div>
<div style="display:none"> Gerrit-Change-Number: 27997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 10 Aug 2018 00:27:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>