<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28011">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/broadwell/Kconfig: Clean up redefined config options<br><br>All broadwell board set HAVE_IFD_BIN to default n, overloading the option in<br>soc, therefore just use the defaults in sb/intel/common/firmware.<br><br>Change-Id: I250dbbc9d61ecedc1a1eb48751ad966732604349<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/google/auron/Kconfig<br>M src/mainboard/google/jecht/Kconfig<br>M src/mainboard/intel/wtm2/Kconfig<br>M src/mainboard/purism/librem_bdw/Kconfig<br>M src/soc/intel/broadwell/Kconfig<br>5 files changed, 0 insertions(+), 38 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/28011/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig</span><br><span>index 92dd9e4..ea0e01f 100644</span><br><span>--- a/src/mainboard/google/auron/Kconfig</span><br><span>+++ b/src/mainboard/google/auron/Kconfig</span><br><span>@@ -74,12 +74,4 @@</span><br><span>  string</span><br><span>       default "pci8086,0406.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif</span><br><span>diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig</span><br><span>index e980205..0720375 100644</span><br><span>--- a/src/mainboard/google/jecht/Kconfig</span><br><span>+++ b/src/mainboard/google/jecht/Kconfig</span><br><span>@@ -55,12 +55,4 @@</span><br><span>         string</span><br><span>       default "pci8086,0406.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif</span><br><span>diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig</span><br><span>index 45a8666..25ffac3 100644</span><br><span>--- a/src/mainboard/intel/wtm2/Kconfig</span><br><span>+++ b/src/mainboard/intel/wtm2/Kconfig</span><br><span>@@ -35,12 +35,4 @@</span><br><span>         string</span><br><span>       default "pci8086,0166.rom"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> endif # BOARD_INTEL_WTM2</span><br><span>diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig</span><br><span>index 726fb4a..fd78087 100644</span><br><span>--- a/src/mainboard/purism/librem_bdw/Kconfig</span><br><span>+++ b/src/mainboard/purism/librem_bdw/Kconfig</span><br><span>@@ -37,14 +37,6 @@</span><br><span> config PCIEXP_AER</span><br><span>     def_bool n</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-       bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-     bool</span><br><span style="color: hsl(0, 100%, 40%);">-    default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> config MAINBOARD_DIR</span><br><span>    string</span><br><span>       default purism/librem_bdw</span><br><span>diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig</span><br><span>index 1b1085a..32148c4 100644</span><br><span>--- a/src/soc/intel/broadwell/Kconfig</span><br><span>+++ b/src/soc/intel/broadwell/Kconfig</span><br><span>@@ -207,12 +207,6 @@</span><br><span> </span><br><span> endif # HAVE_REFCODE_BLOB</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-config HAVE_ME_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-        def_bool y</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config BUILD_WITH_FAKE_IFD</span><br><span style="color: hsl(0, 100%, 40%);">-    def_bool !HAVE_IFD_BIN</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> config CHIPSET_BOOTBLOCK_INCLUDE</span><br><span>   string</span><br><span>       default "soc/intel/broadwell/bootblock/timestamp.inc"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28011">change 28011</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28011"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I250dbbc9d61ecedc1a1eb48751ad966732604349 </div>
<div style="display:none"> Gerrit-Change-Number: 28011 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>