<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27987">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">spi/flash: Add interface to check software write protection<br><br>* Add a common function to check if the region is write protected by<br>** SPI controller's "flash protected regions"<br>** flash status register protection bits<br><br>The state of a possible hardware write protection doesn't matter here.<br><br>Change-Id: I1a2b75f5c0f183a74d42180dfc0c12d50b9780bb<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M src/drivers/spi/spi_flash.c<br>M src/include/spi-generic.h<br>M src/include/spi_flash.h<br>3 files changed, 50 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/27987/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c</span><br><span>index 87049460..0e8ebd9 100644</span><br><span>--- a/src/drivers/spi/spi_flash.c</span><br><span>+++ b/src/drivers/spi/spi_flash.c</span><br><span>@@ -538,6 +538,36 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+int spi_flash_ctrlr_is_region_protected(const struct spi_flash *flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct region *region)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct spi_ctrlr *ctrlr;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct spi_flash_ops *ops;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct region flash_region = { 0 };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!flash)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ flash_region.size = flash->size;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!region_is_subregion(&flash_region, region))</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ctrlr = flash->spi.ctrlr;</span><br><span style="color: hsl(120, 100%, 40%);">+ ops = flash->ops;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check controller's "Protected Regions" */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ctrlr && ctrlr->is_flash_write_protected)</span><br><span style="color: hsl(120, 100%, 40%);">+ return ctrlr->is_flash_write_protected(flash, region);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Try to directly check the status register lock-bits in flash.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ops && ops->get_write_protection)</span><br><span style="color: hsl(120, 100%, 40%);">+ return ops->get_write_protection(flash, region) > 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> int spi_flash_ctrlr_protect_region(const struct spi_flash *flash,</span><br><span> const struct region *region)</span><br><span>diff --git a/src/include/spi-generic.h b/src/include/spi-generic.h</span><br><span>index e3e7f82..c95b4ae 100644</span><br><span>--- a/src/include/spi-generic.h</span><br><span>+++ b/src/include/spi-generic.h</span><br><span>@@ -145,6 +145,8 @@</span><br><span> struct spi_flash *flash);</span><br><span> int (*flash_protect)(const struct spi_flash *flash,</span><br><span> const struct region *region);</span><br><span style="color: hsl(120, 100%, 40%);">+ int (*is_flash_write_protected)(const struct spi_flash *flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct region *region);</span><br><span> };</span><br><span> </span><br><span> /*-----------------------------------------------------------------------</span><br><span>diff --git a/src/include/spi_flash.h b/src/include/spi_flash.h</span><br><span>index f33b59a..b8bb7bd 100644</span><br><span>--- a/src/include/spi_flash.h</span><br><span>+++ b/src/include/spi_flash.h</span><br><span>@@ -198,6 +198,24 @@</span><br><span> const struct region *region);</span><br><span> </span><br><span> /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Check if provided region is write protected.</span><br><span style="color: hsl(120, 100%, 40%);">+ * It first tries to use its controller, if available.</span><br><span style="color: hsl(120, 100%, 40%);">+ * If the controller doesn't support flash protections, try to query the lock</span><br><span style="color: hsl(120, 100%, 40%);">+ * bits in the status register of the flash device (requires flash vendor</span><br><span style="color: hsl(120, 100%, 40%);">+ * specific support).</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param flash The flash device to operate on</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param region The region to lock</span><br><span style="color: hsl(120, 100%, 40%);">+ * @Return < 0 on error, 0 if region isn't fully protected else 1 on success.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Possible errors:</span><br><span style="color: hsl(120, 100%, 40%);">+ * * Invalid region specified</span><br><span style="color: hsl(120, 100%, 40%);">+ * * Requested region layout can't be directly applied on flash</span><br><span style="color: hsl(120, 100%, 40%);">+ * * SPI bus error</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+int spi_flash_ctrlr_is_region_protected(const struct spi_flash *flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct region *region);</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span> * This function is provided to support spi flash command-response transactions.</span><br><span> * Only 2 vectors are supported and the 'func' is called with appropriate</span><br><span> * write and read buffers together. This can be used for chipsets that</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27987">change 27987</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27987"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1a2b75f5c0f183a74d42180dfc0c12d50b9780bb </div>
<div style="display:none"> Gerrit-Change-Number: 27987 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>