<p>Philipp Deppenwiese <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27931">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Philipp Deppenwiese: Looks good to me, approved
  Marshall Dawson: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">security/tpm: Report tpm_unmarshal_response warning<br><br>In procedure tpm_unmarshal_response(), variable "rc" is used early to<br>decide if it should return NULL. Later however, the code proceeds to its<br>end even if one subroutine reports error. If "rc" is not 0, report that<br>there was a partial error in the procedure.<br><br>BUG=b:112253891<br>TEST=Build and boot grunt.<br><br>Change-Id: I7575bc75104fd97f138224aa57561e68f6548e58<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>Reviewed-on: https://review.coreboot.org/27931<br>Reviewed-by: Martin Roth <martinroth@google.com><br>Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/security/tpm/tss/tcg-2.0/tss_marshaling.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c</span><br><span>index 86f2231..94bfbcf 100644</span><br><span>--- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c</span><br><span>+++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c</span><br><span>@@ -554,6 +554,9 @@</span><br><span>                 command, ibuf_remaining(ib));</span><br><span>                 return NULL;</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc)</span><br><span style="color: hsl(120, 100%, 40%);">+               printk(BIOS_WARNING, "Warning: %s had one or more failures.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                     __func__);</span><br><span> </span><br><span>       /* The entire message have been parsed. */</span><br><span>   return tpm2_resp;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27931">change 27931</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27931"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I7575bc75104fd97f138224aa57561e68f6548e58 </div>
<div style="display:none"> Gerrit-Change-Number: 27931 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>