<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27956">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cpu/x86/mp_init.c: Avoid static analysis error for unused value<br><br>Within procedure save_bsp_msrs, the structure pointer "msr_entry" is updated<br>every time procedure save_msr() is called. However, after the last call of<br>save_msr(), "msr_entry" is not used, thus causing a static analysis error.<br>Add a "(void)msr_entry;" at the end to avoid the static analysis error.<br><br>BUG=b:112253891<br>TEST=Build and boot grunt.<br><br>Change-Id: If0fb336fbf49eec3da255fadbe38b3a38768d0cf<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/cpu/x86/mp_init.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/27956/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c</span><br><span>index d124721..4d8b028 100644</span><br><span>--- a/src/cpu/x86/mp_init.c</span><br><span>+++ b/src/cpu/x86/mp_init.c</span><br><span>@@ -296,6 +296,7 @@</span><br><span>         msr_entry = save_msr(MTRR_DEF_TYPE_MSR, msr_entry);</span><br><span> </span><br><span>      fixed_mtrrs_hide_amd_rwdram();</span><br><span style="color: hsl(120, 100%, 40%);">+        (void)msr_entry;</span><br><span> </span><br><span>         return msr_count;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27956">change 27956</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27956"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If0fb336fbf49eec3da255fadbe38b3a38768d0cf </div>
<div style="display:none"> Gerrit-Change-Number: 27956 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>