<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27928">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">device/pci_device.c: Remove unused variable attr setting<br><br>In procedure pci_get_resource, when setting an IO mapped base address,<br>variable attr is &= with PCI_BASE_ADDRESS_IO_ATTR_MASK. However, in this<br>particular code flow variable attr is not used later. Remove the line.<br><br>BUG=b:112253891<br>TEST=Build and boot grunt.<br><br>Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/device/pci_device.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27928/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/device/pci_device.c b/src/device/pci_device.c</span><br><span>index 5938389..b4a8a5c 100644</span><br><span>--- a/src/device/pci_device.c</span><br><span>+++ b/src/device/pci_device.c</span><br><span>@@ -249,7 +249,6 @@</span><br><span>             resource->flags = 0;</span><br><span>      } else if (attr & PCI_BASE_ADDRESS_SPACE_IO) {</span><br><span>           /* An I/O mapped base address. */</span><br><span style="color: hsl(0, 100%, 40%);">-               attr &= PCI_BASE_ADDRESS_IO_ATTR_MASK;</span><br><span>           resource->flags |= IORESOURCE_IO;</span><br><span>                 /* I don't want to deal with 32bit I/O resources. */</span><br><span>             resource->limit = 0xffff;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27928">change 27928</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27928"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69 </div>
<div style="display:none"> Gerrit-Change-Number: 27928 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>