<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27935">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cpu/amd: Misc. formatting improvements<br><br>Remove for() braces from around single lines. Remove extra blank lines.<br><br>Change-Id: I329ac03365e51799581c56eed27ee54de6826f14<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/cpu/amd/agesa/family12/model_12_init.c<br>M src/cpu/amd/agesa/family14/model_14_init.c<br>M src/cpu/amd/agesa/family15tn/model_15_init.c<br>M src/cpu/amd/agesa/family16kb/model_16_init.c<br>M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c<br>M src/cpu/amd/pi/00660F01/model_15_init.c<br>M src/cpu/amd/pi/00730F01/model_16_init.c<br>7 files changed, 5 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/27935/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/amd/agesa/family12/model_12_init.c b/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>index afdfb3b..93aecad 100644</span><br><span>--- a/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>@@ -54,9 +54,8 @@</span><br><span> /* zero the machine check error status registers */</span><br><span> msr.lo = 0;</span><br><span> msr.hi = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < 5; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 5; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> enable_cache();</span><br><span> </span><br><span>diff --git a/src/cpu/amd/agesa/family14/model_14_init.c b/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>index 257f81f..ffb856a 100644</span><br><span>--- a/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>@@ -77,9 +77,8 @@</span><br><span> /* zero the machine check error status registers */</span><br><span> msr.lo = 0;</span><br><span> msr.hi = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < 6; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 6; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> /* Enable the local CPU APICs */</span><br><span> setup_lapic();</span><br><span>diff --git a/src/cpu/amd/agesa/family15tn/model_15_init.c b/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>index 1e0375f..8ae184e 100644</span><br><span>--- a/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>@@ -74,9 +74,8 @@</span><br><span> /* zero the machine check error status registers */</span><br><span> msr.lo = 0;</span><br><span> msr.hi = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < 6; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 6; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> /* Enable the local CPU APICs */</span><br><span> setup_lapic();</span><br><span>diff --git a/src/cpu/amd/agesa/family16kb/model_16_init.c b/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>index 9909793..92c7bca 100644</span><br><span>--- a/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>@@ -72,9 +72,8 @@</span><br><span> /* zero the machine check error status registers */</span><br><span> msr.lo = 0;</span><br><span> msr.hi = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < 6; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 6; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> /* Enable the local CPU APICs */</span><br><span> setup_lapic();</span><br><span>@@ -99,7 +98,6 @@</span><br><span> msr.hi &= ~(1 << (46 - 32));</span><br><span> wrmsr(NB_CFG_MSR, msr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Write protect SMM space with SMMLOCK. */</span><br><span> msr = rdmsr(HWCR_MSR);</span><br><span> msr.lo |= (1 << 0);</span><br><span>diff --git a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>index 61eb813..74d4673 100644</span><br><span>--- a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>+++ b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>@@ -111,9 +111,8 @@</span><br><span> /* zero the machine check error status registers */</span><br><span> msr.lo = 0;</span><br><span> msr.hi = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < 5; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 5; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> enable_cache();</span><br><span> </span><br><span>diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>index 24c2aea..0540a72 100644</span><br><span>--- a/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>+++ b/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>@@ -86,7 +86,6 @@</span><br><span> for (i = 0; i < 6; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Enable the local CPU APICs */</span><br><span> setup_lapic();</span><br><span> </span><br><span>diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>index b9e0185..3ae841d 100644</span><br><span>--- a/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>+++ b/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>@@ -71,7 +71,6 @@</span><br><span> for (i = 0; i < 6; i++)</span><br><span> wrmsr(MC0_STATUS + (i * 4), msr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Enable the local CPU APICs */</span><br><span> setup_lapic();</span><br><span> </span><br><span>@@ -95,7 +94,6 @@</span><br><span> msr.hi &= ~(1 << (46 - 32));</span><br><span> wrmsr(NB_CFG_MSR, msr);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Write protect SMM space with SMMLOCK. */</span><br><span> msr = rdmsr(HWCR_MSR);</span><br><span> msr.lo |= (1 << 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27935">change 27935</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27935"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I329ac03365e51799581c56eed27ee54de6826f14 </div>
<div style="display:none"> Gerrit-Change-Number: 27935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>