<p>Philipp Deppenwiese <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27933">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Justin TerAvest: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">security/tpm: Check for NULL pointer<br><br>Change bce49c2 (security/tpm: Improve TCPA log generation) missed<br>checking for NULL pointer before accessing the tcpa_table returned by<br>tcpa_log_init. This change fixes the boot hang observed on octopus by<br>ensuring pointer is checked for NULL before using it.<br><br>BUG=b:111403731<br>TEST=Verified that octopus boots up fine.<br><br>Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>Reviewed-on: https://review.coreboot.org/27933<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Justin TerAvest <teravest@chromium.org><br>Reviewed-by: Aaron Durbin <adurbin@chromium.org><br>---<br>M src/security/tpm/tspi/log.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c</span><br><span>index 0a6655a..17f6f1f 100644</span><br><span>--- a/src/security/tpm/tspi/log.c</span><br><span>+++ b/src/security/tpm/tspi/log.c</span><br><span>@@ -57,6 +57,10 @@</span><br><span>         struct tcpa_entry *tce;</span><br><span> </span><br><span>  tclt = tcpa_log_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!tclt)</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    if (tclt->num_entries == tclt->max_entries) {</span><br><span>          printk(BIOS_WARNING, "ERROR: TCPA log table is full\n");</span><br><span>           return;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27933">change 27933</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27933"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2 </div>
<div style="display:none"> Gerrit-Change-Number: 27933 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>