<p><a href="https://review.coreboot.org/27904">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/Kconfig">File src/mainboard/intel/coffeelake_rvp/Kconfig:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/Kconfig@14">Patch Set #1, Line 14:</a> <code style="font-family:monospace,monospace">   select UART_DEBUG</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please add select INTEL_GMA_HAVE_VBT and add the respective data.vbt files in the variant dirs.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/Kconfig@66">Patch Set #1, Line 66:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">config ME_BIN_PATH<br>        string<br>        depends on HAVE_ME_BIN<br>        default "3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)/me.bin"<br><br>config EC_BIN_PATH<br>     string<br>        depends on HAVE_EC_BIN<br>        default "3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)/ec.bin"<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be put somewhere else.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Could you reuse southbridge/intel/common/firmware/Kconfig for this?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/dsdt.asl">File src/mainboard/intel/coffeelake_rvp/dsdt.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/dsdt.asl@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace">  </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">shift this and the #endif left</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/smihandler.c">File src/mainboard/intel/coffeelake_rvp/smihandler.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/smihandler.c@27">Patch Set #1, Line 27:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  case 0x99:<br>            printk(BIOS_DEBUG, "Sample\n");<br>             smm_get_gnvs()->smif = 0;<br>          break;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb">File src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98373_NHLT)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would be cleaner to shift this left IMO.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb@171">Patch Set #1, Line 171:</a> <code style="font-family:monospace,monospace">device pci 1f.3 on</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you'll also want this in the devicetree on an #else path for the preprocessor condition.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/gpio.h">File src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27904/1/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/gpio.h@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">/*</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">all these gpio.h files seem quite superfluous. Are they really needed?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27904">change 27904</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27904"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id37bfeb0ae51fd630fec96273216dbb2900782c7 </div>
<div style="display:none"> Gerrit-Change-Number: 27904 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Aug 2018 12:24:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>