<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27867">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/asus/kfsn4-dre: Use common pnp_{enter,exit} functions<br><br>Change-Id: I4b0577bf3c00307733a1096749c1835d86764f29<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/asus/kfsn4-dre/romstage.c<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/27867/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/asus/kfsn4-dre/romstage.c b/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>index 2809f0f..cc198c6 100644</span><br><span>--- a/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>+++ b/src/mainboard/asus/kfsn4-dre/romstage.c</span><br><span>@@ -343,9 +343,7 @@</span><br><span> </span><br><span>       /* Initialize GPIO */</span><br><span>        /* Access SuperIO GPI03 logical device */</span><br><span style="color: hsl(0, 100%, 40%);">-       uint16_t port = GPIO3_DEV >> 8;</span><br><span style="color: hsl(0, 100%, 40%);">-   outb(0x87, port);</span><br><span style="color: hsl(0, 100%, 40%);">-       outb(0x87, port);</span><br><span style="color: hsl(120, 100%, 40%);">+     pnp_enter_conf_state(GPIO3_DEV);</span><br><span>     pnp_set_logical_device(GPIO3_DEV);</span><br><span>   /* Set GP37 (power LED) to output */</span><br><span>         pnp_write_config(GPIO3_DEV, 0xf0, 0x7f);</span><br><span>@@ -355,7 +353,7 @@</span><br><span>       uint8_t cr2c = pnp_read_config(GPIO3_DEV, 0x2c);</span><br><span>     pnp_write_config(GPIO3_DEV, 0x2c, (cr2c & 0xf3) | 0x04);</span><br><span>         /* Restore default SuperIO access */</span><br><span style="color: hsl(0, 100%, 40%);">-    outb(0xaa, port);</span><br><span style="color: hsl(120, 100%, 40%);">+     pnp_exit_conf_state(GPIO3_DEV);</span><br><span> }</span><br><span> </span><br><span> /**</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27867">change 27867</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27867"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b0577bf3c00307733a1096749c1835d86764f29 </div>
<div style="display:none"> Gerrit-Change-Number: 27867 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>