<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27853">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP]drivers/pc80/rtc: Add ACPI support<br><br>Implement GET and SET ACPI methods that take a string to<br>read and write the CMOS variables defined in cmos.layout.<br><br>Change-Id: I358fd745ebfcee6727890653c1f0efcdb8e870b2<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/drivers/pc80/rtc/Makefile.inc<br>A src/drivers/pc80/rtc/acpi/rtc.asl<br>M src/drivers/pc80/rtc/mc146818rtc.c<br>M src/include/pc80/mc146818rtc.h<br>M src/southbridge/intel/bd82x6x/acpi/lpc.asl<br>M src/southbridge/intel/bd82x6x/lpc.c<br>6 files changed, 308 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/27853/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/pc80/rtc/Makefile.inc b/src/drivers/pc80/rtc/Makefile.inc</span><br><span>index 998b7e7..fa4319e 100644</span><br><span>--- a/src/drivers/pc80/rtc/Makefile.inc</span><br><span>+++ b/src/drivers/pc80/rtc/Makefile.inc</span><br><span>@@ -5,6 +5,7 @@</span><br><span> postcar-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c</span><br><span> romstage-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c</span><br><span> ramstage-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-$(CONFIG_DRIVERS_MC146818) += mc146818rtc_ssdt.c</span><br><span> smm-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c</span><br><span> </span><br><span> ifeq ($(CONFIG_USE_OPTION_TABLE),y)</span><br><span>diff --git a/src/drivers/pc80/rtc/acpi/rtc.asl b/src/drivers/pc80/rtc/acpi/rtc.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..37e03ba</span><br><span>--- /dev/null</span><br><span>+++ b/src/drivers/pc80/rtc/acpi/rtc.asl</span><br><span>@@ -0,0 +1,299 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2007-2009 coresystems GmbH</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2012 The Chromium OS Authors</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or</span><br><span style="color: hsl(120, 100%, 40%);">+ * modify it under the terms of the GNU General Public License as</span><br><span style="color: hsl(120, 100%, 40%);">+ * published by the Free Software Foundation; version 2 of</span><br><span style="color: hsl(120, 100%, 40%);">+ * the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Device (CMOS)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, EISAID("PNP0B00"))</span><br><span style="color: hsl(120, 100%, 40%);">+ External (KEY, PkgObj)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OperationRegion (OPR, SystemIO, 0x70, 0x04)</span><br><span style="color: hsl(120, 100%, 40%);">+ Field (OPR, ByteAcc, NoLock, Preserve)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ IDX0, 7,</span><br><span style="color: hsl(120, 100%, 40%);">+ , 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ DAT0, 8,</span><br><span style="color: hsl(120, 100%, 40%);">+ IDX1, 7,</span><br><span style="color: hsl(120, 100%, 40%);">+ , 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ DAT1, 8,</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Mutex for byte read / write access */</span><br><span style="color: hsl(120, 100%, 40%);">+ Mutex (MTX1, 3)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Write byte to CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 Offset in CMOS (0 - 255)</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg1 Byte to write to CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (WRT, 2, Serialized, 3)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LLess(Arg1, 0x100))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX1, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return ()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LGreater (Arg0, 0x7f))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Subtract(Arg0, 0x80), IDX1)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Arg1, DAT1)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Else</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Arg0, IDX0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Arg1, DAT0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX1)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Read byte from CMOS at Arg0</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * @Return: Returns the byte at given address</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (RD, 1, Serialized, 3)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LLess (Arg0, 0x100))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX1, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Zero)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LGreater (Arg0, 0x7f))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Subtract(Arg0, 0x80), IDX1)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DAT1, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Else</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Arg0, IDX0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DAT0, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX1)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Mutex for bit read / write access */</span><br><span style="color: hsl(120, 100%, 40%);">+ Mutex (MTX2, 2)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Write bit to CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 Offset in CMOS (0 - 2047)</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg1 Bit to write to CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (WRTB, 2, Serialized, 2)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LLess(Arg0, 0x800))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX2, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return ()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Divide(Arg0, 8), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (RD (Local0), Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateBitField (Local1, And(Arg0, 7), BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LGreater(Arg1, 0))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (One, BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Else</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ WRT (Local0, Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX2)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Read bit from CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 Offset in CMOS (0 - 2047)</span><br><span style="color: hsl(120, 100%, 40%);">+ * @return Ones on error</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (RDB, 1, Serialized, 2)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LLess(Arg0, 0x800))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX2, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Divide(Arg0, 8), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (RD (Local0), Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateBitField (Local1, And(Arg0, 7), BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (BIT, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX2)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Compare two buffers</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 Buffer</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg1 Buffer</span><br><span style="color: hsl(120, 100%, 40%);">+ * @return 1 if buffers match</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (CMP, 2)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LNotEqual (SizeOf (Arg1), SizeOf (Arg0)))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x00)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (0x00, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ While (LLess (Local0, SizeOf (Arg1)))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LNotEqual (DerefOf (Index (Arg0, Local0)), DerefOf (Index (Arg1, Local0))))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x00)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Increment (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x01)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Find the CMOS option in the KEY lookup table and return the Package</span><br><span style="color: hsl(120, 100%, 40%);">+ * containing it.</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 String of CMOS to find</span><br><span style="color: hsl(120, 100%, 40%);">+ * @return index of Package in KEY, Ones on error</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (FIND, 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (ToString(Arg0), Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ While (LLess(Local0, SizeOf (KEY)))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (KEY, Local0)), Local2)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (Local2, 0)), Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (CMP(Local3, Local1))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Increment (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Mutex for CMOS option read / write access */</span><br><span style="color: hsl(120, 100%, 40%);">+ Mutex (MTX3, 1)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Patch Bit Arg1 of Object Arg0 with value Arg2 and return previous value</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (PATC, 3, Serialized, 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateBitField(Arg0, Arg1, BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (BIT, Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Arg2, BIT)</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Read value to CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 String of CMOS to read</span><br><span style="color: hsl(120, 100%, 40%);">+ * @return Ones on error</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (SET, 2, Serialized, 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (FIND (Arg0), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(Local0, Ones))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local0 Package at index Local0</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (KEY, Local0)), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local1 CMOS start bit</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (Local0, 1)), Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local2 CMOS bit length</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (Local0, 2)), Local2)</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local3 counter</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX3, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ While (LLess(Local3, Local2))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ WRTB (Add(Local1, Local3), PATC(Arg1, Local3, 0))</span><br><span style="color: hsl(120, 100%, 40%);">+ Increment (Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX3)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Zero)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Read value from CMOS</span><br><span style="color: hsl(120, 100%, 40%);">+ * @param Arg0 String of CMOS to write</span><br><span style="color: hsl(120, 100%, 40%);">+ * @return Buffer read</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (GET, 1, Serialized, 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (FIND (Arg0), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(Local0, Ones))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local0 Package at index Local0</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (KEY, Local0)), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local1 CMOS start bit</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (Local0, 1)), Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local2 CMOS bit length</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (DerefOf (Index (Local0, 2)), Local2)</span><br><span style="color: hsl(120, 100%, 40%);">+ // Local3 counter</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Zero, Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+ // Create buffer with length = DIV_ROUND_UP(Local2)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (Buffer (Divide (Add (Local2, 7), 8)) {0}, Local4)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ If (Acquire (^MTX3, 1000))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ While (LLess(Local3, Local2))</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ PATC (Local4, Local3, RDB (Add(Local1, Local3)))</span><br><span style="color: hsl(120, 100%, 40%);">+ Increment (Local3)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Release (^MTX3)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Local4)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>index 34db4c3..1b5d0b7 100644</span><br><span>--- a/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>+++ b/src/drivers/pc80/rtc/mc146818rtc.c</span><br><span>@@ -240,7 +240,7 @@</span><br><span> return CB_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static enum cb_err locate_cmos_layout(struct region_device *rdev)</span><br><span style="color: hsl(120, 100%, 40%);">+enum cb_err locate_cmos_layout(struct region_device *rdev)</span><br><span> {</span><br><span> uint32_t cbfs_type = CBFS_COMPONENT_CMOS_LAYOUT;</span><br><span> struct cbfsf fh;</span><br><span>diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h</span><br><span>index 5d7497d..8f75b16 100644</span><br><span>--- a/src/include/pc80/mc146818rtc.h</span><br><span>+++ b/src/include/pc80/mc146818rtc.h</span><br><span>@@ -5,6 +5,7 @@</span><br><span> </span><br><span> #include <arch/io.h></span><br><span> #include <types.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cbfs.h></span><br><span> </span><br><span> #ifndef RTC_BASE_PORT</span><br><span> #define RTC_BASE_PORT 0x70</span><br><span>@@ -256,6 +257,8 @@</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_USE_OPTION_TABLE)</span><br><span> void sanitize_cmos(void);</span><br><span style="color: hsl(120, 100%, 40%);">+enum cb_err pc80_rtc_ssdt(const char *scope);</span><br><span style="color: hsl(120, 100%, 40%);">+enum cb_err locate_cmos_layout(struct region_device *rdev);</span><br><span> #else</span><br><span> static inline void sanitize_cmos(void) {}</span><br><span> #endif /* CONFIG_USE_OPTION_TABLE */</span><br><span>diff --git a/src/southbridge/intel/bd82x6x/acpi/lpc.asl b/src/southbridge/intel/bd82x6x/acpi/lpc.asl</span><br><span>index 5204b29..cf16e4c 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/acpi/lpc.asl</span><br><span>+++ b/src/southbridge/intel/bd82x6x/acpi/lpc.asl</span><br><span>@@ -67,6 +67,7 @@</span><br><span> #include "irqlinks.asl"</span><br><span> </span><br><span> #include "acpi/ec.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+ #include "drivers/pc80/rtc/acpi/rtc.asl"</span><br><span> </span><br><span> Device (DMAC) // DMA Controller</span><br><span> {</span><br><span>diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>index d9e72b4..c17a3b8 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>@@ -893,9 +893,12 @@</span><br><span> {</span><br><span> struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f, 0));</span><br><span> config_t *chip = dev->chip_info;</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *path = acpi_device_path(dev);</span><br><span> </span><br><span> intel_acpi_pcie_hotplug_generator(chip->pcie_hotplug_map, 8);</span><br><span> intel_acpi_gen_def_acpi_pirq(dev);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_USE_OPTION_TABLE) && path != NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+ pc80_rtc_ssdt(path);</span><br><span> }</span><br><span> </span><br><span> static void lpc_final(struct device *dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27853">change 27853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27853"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I358fd745ebfcee6727890653c1f0efcdb8e870b2 </div>
<div style="display:none"> Gerrit-Change-Number: 27853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>