<p>Gaggery Tsai has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27846">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/intel: Add AML IGD in platform reporting<br><br>This patch revises IGD naming and adds AML IGD in platform reporting.<br><br>BUG=None<br>BRANCH=None<br>TEST=emerge-atlas coreboot chromeos-bootimage & Ensure AML IGD is shown<br> in platform reporting.<br><br>Change-Id: Id8f8379703abdaa5b14a4337a4fca04b370f3a2a<br>Signed-off-by: Gaggery Tsai <gaggery.tsai@intel.com><br>---<br>M src/include/device/pci_ids.h<br>M src/soc/intel/common/block/graphics/graphics.c<br>M src/soc/intel/skylake/bootblock/report_platform.c<br>M src/soc/intel/skylake/vr_config.c<br>4 files changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/27846/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h</span><br><span>index 40f2ea4..56e70ab 100644</span><br><span>--- a/src/include/device/pci_ids.h</span><br><span>+++ b/src/include/device/pci_ids.h</span><br><span>@@ -2868,7 +2868,7 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_GT2_SULTM 0x5916</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR 0x5917</span><br><span> #define PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM 0x591B</span><br><span style="color: hsl(0, 100%, 40%);">-#define PCI_DEVICE_ID_INTEL_KBL_GT2_ULX_R 0x591C</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_AML_GT2_ULX 0x591C</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_IGD_HD_505 0x5a84</span><br><span> #define PCI_DEVICE_ID_INTEL_APL_IGD_HD_500 0x5a85</span><br><span> #define PCI_DEVICE_ID_INTEL_GLK_IGD 0x3184</span><br><span>diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>index c754509..d1023ee 100644</span><br><span>--- a/src/soc/intel/common/block/graphics/graphics.c</span><br><span>+++ b/src/soc/intel/common/block/graphics/graphics.c</span><br><span>@@ -123,7 +123,7 @@</span><br><span> PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR,</span><br><span> PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM,</span><br><span> PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2,</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_DEVICE_ID_INTEL_KBL_GT2_ULX_R,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_DEVICE_ID_INTEL_AML_GT2_ULX,</span><br><span> PCI_DEVICE_ID_INTEL_SKL_GT1_SULTM,</span><br><span> PCI_DEVICE_ID_INTEL_SKL_GT2_SULXM,</span><br><span> PCI_DEVICE_ID_INTEL_SKL_GT2_SULTM,</span><br><span>diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>index 7d5bc3f..a652b52 100644</span><br><span>--- a/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>+++ b/src/soc/intel/skylake/bootblock/report_platform.c</span><br><span>@@ -102,6 +102,7 @@</span><br><span> { PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR, "Kabylake-R ULT GT2"},</span><br><span> { PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM, "Kabylake HALO GT2" },</span><br><span> { PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2, "Kabylake DT GT2" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_DEVICE_ID_INTEL_AML_GT2_ULX, "Amberlake ULX GT2" },</span><br><span> };</span><br><span> </span><br><span> static uint8_t get_dev_revision(pci_devfn_t dev)</span><br><span>diff --git a/src/soc/intel/skylake/vr_config.c b/src/soc/intel/skylake/vr_config.c</span><br><span>index ce40e35..4508fda 100644</span><br><span>--- a/src/soc/intel/skylake/vr_config.c</span><br><span>+++ b/src/soc/intel/skylake/vr_config.c</span><br><span>@@ -186,7 +186,7 @@</span><br><span> sku = KBL_R_SKU;</span><br><span> else if (id == PCI_DEVICE_ID_INTEL_KBL_ID_Y) {</span><br><span> id = get_dev_id(SA_DEV_IGD);</span><br><span style="color: hsl(0, 100%, 40%);">- if (id == PCI_DEVICE_ID_INTEL_KBL_GT2_ULX_R)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (id == PCI_DEVICE_ID_INTEL_AML_GT2_ULX)</span><br><span> sku = AML_Y_SKU;</span><br><span> else</span><br><span> sku = KBL_Y_SKU;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27846">change 27846</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27846"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id8f8379703abdaa5b14a4337a4fca04b370f3a2a </div>
<div style="display:none"> Gerrit-Change-Number: 27846 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Gaggery Tsai <gaggery.tsai@intel.com> </div>