<p>Sumeet R Pawnikar has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27819">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus/variants/baseboard: Update Power Limit1<br><br>Update power limit1 value from 8W to 10W. There is an error<br>in the energy calculation for current VR solution on GLK.<br>Experiments show that when power limit1 set to 10W, gained<br>performance improvement with SoC TDP reaches max (6W) power.<br><br>BUG=b:79779737<br>BRANCH=None<br>TEST=Build coreboot for Octopus board.<br><br>Change-Id: Ic320d442e7401e4be2e8e16d691db4c803f0fdc1<br>Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/devicetree.cb<br>M src/mainboard/google/octopus/variants/baseboard/include/baseboard/acpi/dptf.asl<br>2 files changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/27819/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb</span><br><span>index 9cab69c..b7c7ad2 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb</span><br><span>@@ -42,11 +42,10 @@</span><br><span>         register "gpe0_dw2" = "PMC_GPE_N_95_64"</span><br><span>  register "gpe0_dw3" = "PMC_GPE_N_63_32"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- # PL1 override 8000 mW: Due to error in the energy calculation for</span><br><span style="color: hsl(120, 100%, 40%);">+    # PL1 override 10000 mW: Due to error in the energy calculation for</span><br><span>  # current VR solution. Experiments show that SoC TDP max (6W) can</span><br><span style="color: hsl(0, 100%, 40%);">-       # be reached when RAPL PL1 is set to 8W.</span><br><span style="color: hsl(0, 100%, 40%);">-        # TODO: Need to tune this value on closed chassis system.</span><br><span style="color: hsl(0, 100%, 40%);">-       register "tdp_pl1_override_mw" = "8000"</span><br><span style="color: hsl(120, 100%, 40%);">+   # be reached when RAPL PL1 is set to 10W.</span><br><span style="color: hsl(120, 100%, 40%);">+     register "tdp_pl1_override_mw" = "10000"</span><br><span>         # Set RAPL PL2 to 15W.</span><br><span>       register "tdp_pl2_override_mw" = "15000"</span><br><span> </span><br><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/acpi/dptf.asl b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/acpi/dptf.asl</span><br><span>index fb5b590..0b26129 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/acpi/dptf.asl</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/acpi/dptf.asl</span><br><span>@@ -69,8 +69,7 @@</span><br><span>        Package () {    /* Power Limit 1 */</span><br><span>          0,      /* PowerLimitIndex, 0 for Power Limit 1 */</span><br><span>           3000,   /* PowerLimitMinimum */</span><br><span style="color: hsl(0, 100%, 40%);">-         /* TODO: Need to tune this value on closed chassis system. */</span><br><span style="color: hsl(0, 100%, 40%);">-           8000,   /* PowerLimitMaximum */</span><br><span style="color: hsl(120, 100%, 40%);">+               10000,  /* PowerLimitMaximum */</span><br><span>              1000,   /* TimeWindowMinimum */</span><br><span>              1000,   /* TimeWindowMaximum */</span><br><span>              200     /* StepSize */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27819">change 27819</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27819"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic320d442e7401e4be2e8e16d691db4c803f0fdc1 </div>
<div style="display:none"> Gerrit-Change-Number: 27819 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> </div>