<p>Caveh Jalali would like caveh jalali to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/27791">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/atlas: Not not override icc_max<br><br>Skylake SoC code now sets the icc_max based on the CPU SKU, so we<br>should not hard-code it in the device tree.<br><br>BUG=b:110890675<br>BRANCH=None<br>TEST=boots on atlas<br><br>Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33<br>Signed-off-by: Caveh Jalali <caveh@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/atlas/devicetree.cb<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27791/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>index f6610df..98a49bc 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>@@ -86,7 +86,7 @@</span><br><span>         #| Psi4Enable     | 1     | 1     | 1     | 1     |</span><br><span>  #| ImonSlope      | 0     | 0     | 0     | 0     |</span><br><span>  #| ImonOffset     | 0     | 0     | 0     | 0     |</span><br><span style="color: hsl(0, 100%, 40%);">-     #| IccMax         | 4A    | 24A   | 24A   | 24A   |</span><br><span style="color: hsl(120, 100%, 40%);">+   #| IccMax         | 0     | 0     | 0     | 0     |</span><br><span>  #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span>  #| AcLoadline     | 14.9  | 5     | 5.7   | 4.57  |</span><br><span>  #| DcLoadline     | 14.2  | 4.86  | 4.2   | 4.3   |</span><br><span>@@ -100,7 +100,7 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(4),</span><br><span style="color: hsl(120, 100%, 40%);">+             .icc_max = 0,</span><br><span>                .voltage_limit = 1520,</span><br><span>               .ac_loadline = 1490,</span><br><span>                 .dc_loadline = 1420,</span><br><span>@@ -115,7 +115,7 @@</span><br><span>           .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(24),</span><br><span style="color: hsl(120, 100%, 40%);">+            .icc_max = 0,</span><br><span>                .voltage_limit = 1520,</span><br><span>               .ac_loadline = 500,</span><br><span>          .dc_loadline = 486,</span><br><span>@@ -130,7 +130,7 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(24),</span><br><span style="color: hsl(120, 100%, 40%);">+            .icc_max = 0,</span><br><span>                .voltage_limit = 1520,</span><br><span>               .ac_loadline = 570,</span><br><span>          .dc_loadline = 420,</span><br><span>@@ -145,7 +145,7 @@</span><br><span>            .psi4enable = 1,</span><br><span>             .imon_slope = 0x0,</span><br><span>           .imon_offset = 0x0,</span><br><span style="color: hsl(0, 100%, 40%);">-             .icc_max = VR_CFG_AMP(24),</span><br><span style="color: hsl(120, 100%, 40%);">+            .icc_max = 0,</span><br><span>                .voltage_limit = 1520,</span><br><span>               .ac_loadline = 457,</span><br><span>          .dc_loadline = 430,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27791">change 27791</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27791"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 </div>
<div style="display:none"> Gerrit-Change-Number: 27791 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>