<p>Philipp Deppenwiese has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27767">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">southbridge/intel: Remove leftover TPM ACPI code<br><br>Remove ACPI code which isn't necessary anymore due<br>to the LPC TPM ACPI generator.<br><br>Change-Id: I2fae286d61ec7c1036d1a8fa800dc8d9603252e9<br>Signed-off-by: Philipp Deppenwiese <zaolin@das-labor.org><br>---<br>M src/southbridge/intel/i82801gx/acpi/lpc.asl<br>M src/southbridge/intel/lynxpoint/acpi/lpc.asl<br>2 files changed, 0 insertions(+), 46 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/27767/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/intel/i82801gx/acpi/lpc.asl b/src/southbridge/intel/i82801gx/acpi/lpc.asl</span><br><span>index 2bcd06f..87eab07 100644</span><br><span>--- a/src/southbridge/intel/i82801gx/acpi/lpc.asl</span><br><span>+++ b/src/southbridge/intel/i82801gx/acpi/lpc.asl</span><br><span>@@ -199,29 +199,6 @@</span><br><span> </span><br><span> #include "acpi/superio.asl"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_LPC_TPM)</span><br><span style="color: hsl(0, 100%, 40%);">- Device (TPM) // Trusted Platform Module</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EISAID("IFX0102"))</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_CID, 0x310cd041)</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_UID, 1)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- If (TPMP) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0xf)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x0)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_CRS, ResourceTemplate() {</span><br><span style="color: hsl(0, 100%, 40%);">- IO (Decode16, 0x2e, 0x2e, 0x01, 0x02)</span><br><span style="color: hsl(0, 100%, 40%);">- IO (Decode16, 0x6f0, 0x6f0, 0x01, 0x10)</span><br><span style="color: hsl(0, 100%, 40%);">- Memory32Fixed (ReadWrite, 0xfed40000, 0x5000)</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Device (PS2K) // Keyboard</span><br><span> {</span><br><span> Name(_HID, EISAID("PNP0303"))</span><br><span>diff --git a/src/southbridge/intel/lynxpoint/acpi/lpc.asl b/src/southbridge/intel/lynxpoint/acpi/lpc.asl</span><br><span>index 1df49e3..b677e6a 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/acpi/lpc.asl</span><br><span>+++ b/src/southbridge/intel/lynxpoint/acpi/lpc.asl</span><br><span>@@ -223,27 +223,4 @@</span><br><span> }</span><br><span> </span><br><span> #include "acpi/superio.asl"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_LPC_TPM)</span><br><span style="color: hsl(0, 100%, 40%);">- Device (TPM) // Trusted Platform Module</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EISAID("IFX0102"))</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_CID, 0x310cd041)</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_UID, 1)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Method(_STA, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- If (TPMP) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0xf)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x0)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_CRS, ResourceTemplate() {</span><br><span style="color: hsl(0, 100%, 40%);">- IO (Decode16, 0x2e, 0x2e, 0x01, 0x02)</span><br><span style="color: hsl(0, 100%, 40%);">- IO (Decode16, 0x6f0, 0x6f0, 0x01, 0x10)</span><br><span style="color: hsl(0, 100%, 40%);">- Memory32Fixed (ReadWrite, 0xfed40000, 0x5000)</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27767">change 27767</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27767"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2fae286d61ec7c1036d1a8fa800dc8d9603252e9 </div>
<div style="display:none"> Gerrit-Change-Number: 27767 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>