<p><a href="https://review.coreboot.org/18224">View Change</a></p><p>18 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c">File util/bucts/bucts.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@31">Patch Set #5, Line 31:</a> <code style="font-family:monospace,monospace">#if defined (__sun) && (defined(__i386) || defined(__amd64))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@75">Patch Set #5, Line 75:</a> <code style="font-family:monospace,monospace"> return MAP_FAILED == virt_addr ? NULL : virt_addr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@113">Patch Set #5, Line 113:</a> <code style="font-family:monospace,monospace"> if (EINVAL == errno) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@131">Patch Set #5, Line 131:</a> <code style="font-family:monospace,monospace">static int get_platform_info(struct pci_dev *sb, int *has_var_bb, uint32_t *rcba_addr)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@238">Patch Set #5, Line 238:</a> <code style="font-family:monospace,monospace"> int spi_is_bootdevice = ((*(uint16_t *)(rcba + GCS_OFFSET) >> 10) & 3) == 3;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@241">Patch Set #5, Line 241:</a> <code style="font-family:monospace,monospace"> *(uint32_t *)(rcba + SPIBAR + FDOC) = (PCHSTRAPS_SECTION << 12) | 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@262">Patch Set #5, Line 262:</a> <code style="font-family:monospace,monospace"> ? "set, changing top swap not possible" : "unset, changing top swap is possible");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@263">Patch Set #5, Line 263:</a> <code style="font-family:monospace,monospace"> printf("Top Swap : %s\n", ts ? "Enabled" : "Disabled");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@266">Patch Set #5, Line 266:</a> <code style="font-family:monospace,monospace"> printf("Ranges swapped : 0x%llx-0x%08llx <-> 0x%08llx-0x%08llx",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@289">Patch Set #5, Line 289:</a> <code style="font-family:monospace,monospace"> printf("BIOS Interface Lock-Down set, Changing Top Swap not possible.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@342">Patch Set #5, Line 342:</a> <code style="font-family:monospace,monospace"> printf("Invalid setting: multiple set/unset arguments\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@346">Patch Set #5, Line 346:</a> <code style="font-family:monospace,monospace"> printf("Print and Set are mutually exclusive!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@354">Patch Set #5, Line 354:</a> <code style="font-family:monospace,monospace"> printf("Invalid setting: multiple set/unset arguments\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@358">Patch Set #5, Line 358:</a> <code style="font-family:monospace,monospace"> printf("Print and Set are mutually exclusive!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@366">Patch Set #5, Line 366:</a> <code style="font-family:monospace,monospace"> printf("Print and Set are mutually exclusive!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@375">Patch Set #5, Line 375:</a> <code style="font-family:monospace,monospace"> default:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible switch case/default not preceded by break or fallthrough comment</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@389">Patch Set #5, Line 389:</a> <code style="font-family:monospace,monospace"> if ((io_fd = open("/dev/io", O_RDWR)) < 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/18224/5/util/bucts/bucts.c@399">Patch Set #5, Line 399:</a> <code style="font-family:monospace,monospace"> if (-1 == (fd_mem = open(MEM_DEV, O_RDWR | O_SYNC))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/18224">change 18224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/18224"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I12cc2e91396f096fc979e23848e1929cb6c44fc5 </div>
<div style="display:none"> Gerrit-Change-Number: 18224 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 01 Aug 2018 19:45:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>