<p>Seunghwan Kim has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27773">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nautilus: Set CABC_EN to GPO high before EDP power on<br><br>If GPP_E22(CABC_EN) remained floating GPI(SoC default) at V3.3_DX_EDP on,<br>it may cause damage on the GPIO pad.<br><br>To prevent, we would set this pad to GPO on romstage before EDP power on.<br><br>Since we need to cover all systems in market, I put it into romstage<br>instead of early_gpio_table.<br><br>BUG=b:111860510<br>BRANCH=poppy<br>TEST=Verified CABC_EN is set to GPO high 5ms before EDP power on<br><br>Change-Id: I34e2fe86329a88eb05e0ea3c6beac6a64754b41e<br>Signed-off-by: Seunghwan Kim <sh_.kim@samsung.com><br>---<br>M src/mainboard/google/poppy/variants/nautilus/memory.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/27773/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nautilus/memory.c b/src/mainboard/google/poppy/variants/nautilus/memory.c</span><br><span>index dc845bc..bf2accf 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nautilus/memory.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nautilus/memory.c</span><br><span>@@ -14,6 +14,7 @@</span><br><span>  */</span><br><span> </span><br><span> #include <baseboard/variants.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gpio.h></span><br><span> </span><br><span> /* DQ byte map */</span><br><span> static const u8 dq_map[][12] = {</span><br><span>@@ -46,4 +47,8 @@</span><br><span>    p->rcomp_resistor_size = sizeof(rcomp_resistor);</span><br><span>  p->rcomp_target = rcomp_target;</span><br><span>   p->rcomp_target_size = sizeof(rcomp_target);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Ensure GPP_E22(CABC_EN) is set to GPO before enabling V3.3_DX_EDP.</span><br><span style="color: hsl(120, 100%, 40%);">+  * If it is remained floating GPI, it may cause damage on the pad.*/</span><br><span style="color: hsl(120, 100%, 40%);">+  gpio_output(GPP_E22, 1);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27773">change 27773</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27773"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I34e2fe86329a88eb05e0ea3c6beac6a64754b41e </div>
<div style="display:none"> Gerrit-Change-Number: 27773 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Seunghwan Kim <sh_.kim@samsung.com> </div>