<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27759">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/cyan: Switch Touchpad and Touchscreen interrupts to be level-triggered<br><br>Adapted from chromium commit 126d352<br>[Strago: switch Touchpad and Touchscreen interrupts to be level-triggered]<br><br>The Elan and other touch controllers found in this device work much<br>more reliably if used with level-triggered interrupts rather than<br>edge-triggered.<br><br>TEST=Boot several cyan boards, verify that touchpad and touchscreen<br>work.<br><br>Original-Change-Id: I59d05d9dfa9c41e5472d756ef51f0817a503c889<br>Original-Signed-off-by: Dmitry Torokhov <dtor@chromium.org><br>Original-Reviewed-on: https://chromium-review.googlesource.com/894689<br>Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org><br><br>Change-Id: Ia4f8cf83351dae0d78995ce0b0ed902d1e4ac3e8<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/cyan/acpi/trackpad_atmel.asl<br>M src/mainboard/google/cyan/variants/banon/gpio.c<br>M src/mainboard/google/cyan/variants/celes/gpio.c<br>M src/mainboard/google/cyan/variants/cyan/gpio.c<br>M src/mainboard/google/cyan/variants/edgar/gpio.c<br>M src/mainboard/google/cyan/variants/kefka/gpio.c<br>M src/mainboard/google/cyan/variants/reks/gpio.c<br>M src/mainboard/google/cyan/variants/relm/gpio.c<br>M src/mainboard/google/cyan/variants/setzer/gpio.c<br>M src/mainboard/google/cyan/variants/terra/gpio.c<br>M src/mainboard/google/cyan/variants/ultima/gpio.c<br>M src/mainboard/google/cyan/variants/wizpig/gpio.c<br>12 files changed, 20 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27759/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl</span><br><span>index 96ec3db..96f3185 100644</span><br><span>--- a/src/mainboard/google/cyan/acpi/trackpad_atmel.asl</span><br><span>+++ b/src/mainboard/google/cyan/acpi/trackpad_atmel.asl</span><br><span>@@ -33,7 +33,7 @@</span><br><span> AddressingMode7Bit, // AddressingMode</span><br><span> "\\_SB.PCI0.I2C6", // ResourceSource</span><br><span> )</span><br><span style="color: hsl(0, 100%, 40%);">- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span> "\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }</span><br><span> })</span><br><span> </span><br><span>diff --git a/src/mainboard/google/cyan/variants/banon/gpio.c b/src/mainboard/google/cyan/variants/banon/gpio.c</span><br><span>index e077bcc..92ef836 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/banon/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/banon/gpio.c</span><br><span>@@ -161,9 +161,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/celes/gpio.c b/src/mainboard/google/cyan/variants/celes/gpio.c</span><br><span>index ebb7717..10ca3b0 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/celes/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/celes/gpio.c</span><br><span>@@ -164,7 +164,7 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span> GPIO_NC,</span><br><span> /* 19 GPIO_SUS1 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/cyan/gpio.c b/src/mainboard/google/cyan/variants/cyan/gpio.c</span><br><span>index 340a8af..62fcb5e 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/cyan/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/cyan/gpio.c</span><br><span>@@ -162,9 +162,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/edgar/gpio.c b/src/mainboard/google/cyan/variants/edgar/gpio.c</span><br><span>index 779b336..97e2dd1 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/edgar/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/edgar/gpio.c</span><br><span>@@ -161,7 +161,7 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span> GPIO_NC, /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/kefka/gpio.c b/src/mainboard/google/cyan/variants/kefka/gpio.c</span><br><span>index 00a6e26..8340f1a 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/kefka/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/kefka/gpio.c</span><br><span>@@ -161,9 +161,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/reks/gpio.c b/src/mainboard/google/cyan/variants/reks/gpio.c</span><br><span>index eac413b..74792bd 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/reks/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/reks/gpio.c</span><br><span>@@ -163,9 +163,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/relm/gpio.c b/src/mainboard/google/cyan/variants/relm/gpio.c</span><br><span>index 8bd911c..6b75a84 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/relm/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/relm/gpio.c</span><br><span>@@ -164,9 +164,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/setzer/gpio.c b/src/mainboard/google/cyan/variants/setzer/gpio.c</span><br><span>index 2278200..a1564c1 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/setzer/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/setzer/gpio.c</span><br><span>@@ -162,9 +162,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/terra/gpio.c b/src/mainboard/google/cyan/variants/terra/gpio.c</span><br><span>index 8c87916..3f5c19d 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/terra/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/terra/gpio.c</span><br><span>@@ -160,7 +160,7 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span> GPIO_NC, /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/ultima/gpio.c b/src/mainboard/google/cyan/variants/ultima/gpio.c</span><br><span>index 94e5066..4e4f0f6 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/ultima/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/ultima/gpio.c</span><br><span>@@ -163,9 +163,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_NC, /* 21 SEC_GPIO_SUS11 */</span><br><span>diff --git a/src/mainboard/google/cyan/variants/wizpig/gpio.c b/src/mainboard/google/cyan/variants/wizpig/gpio.c</span><br><span>index ee94ac4..cadaf02 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/wizpig/gpio.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/wizpig/gpio.c</span><br><span>@@ -162,9 +162,9 @@</span><br><span> GPO_FUNC(NA, NA), /* 16 SEC_GPIO_SUS10 */</span><br><span> GPI(trig_edge_low, L0, P_1K_H, non_maskable, NA, NA, NA),</span><br><span> /* 17 GPIO_SUS3 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 18 GPIO_SUS7 */</span><br><span style="color: hsl(0, 100%, 40%);">- GPI(trig_edge_low, L3, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),</span><br><span style="color: hsl(120, 100%, 40%);">+ GPI(trig_level_low, L1, P_1K_H, 0, NA, UNMASK_WAKE, NA),</span><br><span> /* 19 GPIO_SUS1 */</span><br><span> GPIO_NC, /* 20 GPIO_SUS5 */</span><br><span> GPIO_INPUT_NO_PULL, /* 21 SEC_GPIO_SUS11 */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27759">change 27759</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27759"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia4f8cf83351dae0d78995ce0b0ed902d1e4ac3e8 </div>
<div style="display:none"> Gerrit-Change-Number: 27759 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>