<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27763">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/edgar: Add support for additional RAM types/configs<br><br>Adapted from chromium commits 2319742 and 3b59fb2<br>[Edgar: Add Micron MT52L256M32D1PF-107 SPD data]<br>[Edgar: Add Hynix H9CCNNN8GTALAR-NUD and Nanya NT6CL256T32CM-H1 SPD data]<br><br>Supported 2nd source Hynix, Micron, and Nanya memory.<br><br>TEST=Built and used mosys command by "mosys -k memory spd print all"<br><br>Original-Change-Id: Iec9160b74d2812620d2d28f841d503e2d63c8579<br>Original-Change-Id: I610f01a0198f835a2038511ff78bf0cfba7812a0<br>Original-Signed-off-by: Hank2_Lin <Hank2_Lin@pegatroncorp.com><br>Original-Reviewed-by: Vincent Wang <vwang@chromium.org><br>Original-Reviewed-by: YH Lin <yueherngl@chromium.org><br>Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org><br><br>Change-Id: If2379d6e58425616f49d77b0cdea1cd90f9a8bfa<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>A src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex<br>M src/mainboard/google/cyan/variants/edgar/Makefile.inc<br>M src/mainboard/google/cyan/variants/edgar/spd_util.c<br>3 files changed, 46 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/27763/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex b/src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex</span><br><span>new file mode 100644</span><br><span>index 0000000..d24c980</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/cyan/spd/nanya_dimm_NT6CL256T32CM-H1.spd.hex</span><br><span>@@ -0,0 +1,16 @@</span><br><span style="color: hsl(120, 100%, 40%);">+91 20 F1 00 04 11 05 0B 03 11 01 08 09 00 40 05</span><br><span style="color: hsl(120, 100%, 40%);">+67 78 90 50 90 11 50 E0 10 04 3C 3C 01 90 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 A0 CA E6 00 00 00 A8 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 1F 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 83 0B 00 00 00 00 00 00 00 63 4D</span><br><span style="color: hsl(120, 100%, 40%);">+4E 54 36 43 4C 32 35 36 54 33 32 43 4D 2D 48 31</span><br><span style="color: hsl(120, 100%, 40%);">+20 20 00 00 83 0B 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(120, 100%, 40%);">+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span>diff --git a/src/mainboard/google/cyan/variants/edgar/Makefile.inc b/src/mainboard/google/cyan/variants/edgar/Makefile.inc</span><br><span>index e553c88..2e8b02c 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/edgar/Makefile.inc</span><br><span>+++ b/src/mainboard/google/cyan/variants/edgar/Makefile.inc</span><br><span>@@ -25,8 +25,13 @@</span><br><span> SPD_SOURCES += samsung_dimm_K4E8E304EE-EGCE</span><br><span> SPD_SOURCES += hynix_dimm_H9CCNNN8JTBLAR-NUD</span><br><span> SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += empty</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107</span><br><span> SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += nanya_dimm_NT6CL256T32CM-H1</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += nanya_dimm_NT6CL256T32CM-H1</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD</span><br><span> </span><br><span> SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)</span><br><span> </span><br><span>diff --git a/src/mainboard/google/cyan/variants/edgar/spd_util.c b/src/mainboard/google/cyan/variants/edgar/spd_util.c</span><br><span>index 9651c27..f9b3681 100644</span><br><span>--- a/src/mainboard/google/cyan/variants/edgar/spd_util.c</span><br><span>+++ b/src/mainboard/google/cyan/variants/edgar/spd_util.c</span><br><span>@@ -23,9 +23,14 @@</span><br><span> * 0b0001 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8JTBLAR-NUD</span><br><span> * 0b0010 - 2GiB total - 1 x 2GiB Samsung K4E8E304EE-EGCE</span><br><span> * 0b0011 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8JTBLAR-NUD</span><br><span style="color: hsl(0, 100%, 40%);">- * 0b0100 - 4GiB total - 2 x 2GiB Samsung K4E8E324EB-EGCF</span><br><span style="color: hsl(0, 100%, 40%);">- * 0b0101 - TBD</span><br><span style="color: hsl(0, 100%, 40%);">- * 0b0110 - 2GiB total - 1 x 2GiB Samsung K4E8E324EB-EGCF</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b0100 - 8GiB total - 2 x 4GiB Samsung K4E8E324EB-EGCF (dual)</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b0101 - 4GiB total - 2 x 2GiB Micron LPDDR3 MT52L256M32D1PF-107 (dual)</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b0110 - 4GiB total - 1 x 4GiB Samsung K4E8E324EB-EGCF</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b0111 - 2GiB total - 1 x 2GiB Micron LPDDR3 MT52L256M32D1PF-107</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b1000 - 4GiB total - 2 x 2GiB NANYA NT6CL256T32CM-H1 (dual)</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b1001 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8GTALAR-NUD (dual)</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b1010 - 2GiB total - 1 x 2GiB NANYA NT6CL256T32CM-H1</span><br><span style="color: hsl(120, 100%, 40%);">+ * 0b1011 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8GTALAR-NUD</span><br><span> */</span><br><span> </span><br><span> int get_variant_spd_index(int ram_id, int *dual)</span><br><span>@@ -52,11 +57,26 @@</span><br><span> printk(BIOS_DEBUG, "4GiB Samsung K4E8E324EB-EGCF\n");</span><br><span> break;</span><br><span> case 5:</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_DEBUG, "empty\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "4GiB Micron LPDDR3 MT52L256M32D1PF-107\n");</span><br><span> break;</span><br><span> case 6:</span><br><span> printk(BIOS_DEBUG, "2GiB Samsung K4E8E324EB-EGCF\n");</span><br><span> break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 7:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "2GiB Micron LPDDR3 MT52L256M32D1PF-107\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 8:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "4GiB NANYA NT6CL256T32CM-H1\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 9:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "4GiB Hynix H9CCNNN8GTALAR-NUD\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 10:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "2GiB NANYA NT6CL256T32CM-H1\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 11:</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "2GiB Hynix H9CCNNN8GTALAR-NUD\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> }</span><br><span> </span><br><span> /* 1:1 mapping between ram_id and spd_index for edgar */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27763">change 27763</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27763"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If2379d6e58425616f49d77b0cdea1cd90f9a8bfa </div>
<div style="display:none"> Gerrit-Change-Number: 27763 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>