<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27679">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/parrot/smihandler: Use new PMBASE API<br><br>Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>Reviewed-on: https://review.coreboot.org/27679<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/google/parrot/smihandler.c<br>1 file changed, 3 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c</span><br><span>index 7681065..e30f78f 100644</span><br><span>--- a/src/mainboard/google/parrot/smihandler.c</span><br><span>+++ b/src/mainboard/google/parrot/smihandler.c</span><br><span>@@ -20,6 +20,7 @@</span><br><span> #include <southbridge/intel/bd82x6x/pch.h></span><br><span> #include <southbridge/intel/bd82x6x/me.h></span><br><span> #include <southbridge/intel/common/pmutil.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <southbridge/intel/common/pmbase.h></span><br><span> #include <northbridge/intel/sandybridge/sandybridge.h></span><br><span> #include <cpu/intel/model_206ax/model_206ax.h></span><br><span> #include <elog.h></span><br><span>@@ -29,7 +30,6 @@</span><br><span> static u8 mainboard_smi_ec(void)</span><br><span> {</span><br><span>       u8 src;</span><br><span style="color: hsl(0, 100%, 40%);">- u32 pm1_cnt;</span><br><span> #if IS_ENABLED(CONFIG_ELOG_GSMI)</span><br><span>     static int battery_critical_logged;</span><br><span> #endif</span><br><span>@@ -54,9 +54,7 @@</span><br><span>            elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);</span><br><span> #endif</span><br><span>              /* Go to S5 */</span><br><span style="color: hsl(0, 100%, 40%);">-          pm1_cnt = inl(smm_get_pmbase() + PM1_CNT);</span><br><span style="color: hsl(0, 100%, 40%);">-              pm1_cnt |= (0xf << 10);</span><br><span style="color: hsl(0, 100%, 40%);">-           outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);</span><br><span style="color: hsl(120, 100%, 40%);">+            write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));</span><br><span>                 break;</span><br><span>       }</span><br><span> </span><br><span>@@ -65,8 +63,6 @@</span><br><span> </span><br><span> void mainboard_smi_gpi(u32 gpi_sts)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       u32 pm1_cnt;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts);</span><br><span>    if (gpi_sts & (1 << EC_SMI_GPI)) {</span><br><span>                 /* Process all pending events from EC */</span><br><span>@@ -79,9 +75,7 @@</span><br><span>                 elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED);</span><br><span> #endif</span><br><span>              /* Go to S5 */</span><br><span style="color: hsl(0, 100%, 40%);">-          pm1_cnt = inl(smm_get_pmbase() + PM1_CNT);</span><br><span style="color: hsl(0, 100%, 40%);">-              pm1_cnt |= (0xf << 10);</span><br><span style="color: hsl(0, 100%, 40%);">-           outl(pm1_cnt, smm_get_pmbase() + PM1_CNT);</span><br><span style="color: hsl(120, 100%, 40%);">+            write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10));</span><br><span>         }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27679">change 27679</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27679"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e </div>
<div style="display:none"> Gerrit-Change-Number: 27679 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>