<p><a href="https://review.coreboot.org/27712">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27712/1/src/northbridge/intel/sandybridge/raminit.c">File src/northbridge/intel/sandybridge/raminit.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27712/1/src/northbridge/intel/sandybridge/raminit.c@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace">#define MRC_CACHE_VERSION 1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">could you add a comment here or where the struct is defined to update this if the struct gets changed?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27712">change 27712</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27712"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Icd6f31bf0b30a42c66e18ab83d2434f9c3084211 </div>
<div style="display:none"> Gerrit-Change-Number: 27712 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 29 Jul 2018 10:46:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>