<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27668">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pnp_device: don't treat missing PNP_MSC devicetree entry as error<br><br>Change-Id: I8da01cd462225b633bf2043ab33b35aeddc8d55a<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/device/pnp_device.c<br>1 file changed, 15 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27668/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c</span><br><span>index 09a2748..e56b00d 100644</span><br><span>--- a/src/device/pnp_device.c</span><br><span>+++ b/src/device/pnp_device.c</span><br><span>@@ -118,9 +118,21 @@</span><br><span> static void pnp_set_resource(struct device *dev, struct resource *resource)</span><br><span> {</span><br><span>        if (!(resource->flags & IORESOURCE_ASSIGNED)) {</span><br><span style="color: hsl(0, 100%, 40%);">-          printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "not assigned\n", dev_path(dev), resource->index,</span><br><span style="color: hsl(0, 100%, 40%);">-                  resource_type(resource), resource->size);</span><br><span style="color: hsl(120, 100%, 40%);">+           /* The PNP_MSC super IO registers have the IRQ flag set. If no</span><br><span style="color: hsl(120, 100%, 40%);">+                   value is assigned in the devicetree, the corresponding</span><br><span style="color: hsl(120, 100%, 40%);">+                PNP_MSC register doesn't get written, which should be printed</span><br><span style="color: hsl(120, 100%, 40%);">+             as warning and not as error. */</span><br><span style="color: hsl(120, 100%, 40%);">+            if (resource->flags & IORESOURCE_IRQ &&</span><br><span style="color: hsl(120, 100%, 40%);">+                    (resource->index != PNP_IDX_IRQ0) &&</span><br><span style="color: hsl(120, 100%, 40%);">+               (resource->index != PNP_IDX_IRQ1))</span><br><span style="color: hsl(120, 100%, 40%);">+                     printk(BIOS_WARNING, "WARNING: %s %02lx %s size: "</span><br><span style="color: hsl(120, 100%, 40%);">+                         "0x%010llx not assigned\n", dev_path(dev),</span><br><span style="color: hsl(120, 100%, 40%);">+                          resource->index, resource_type(resource),</span><br><span style="color: hsl(120, 100%, 40%);">+                          resource->size);</span><br><span style="color: hsl(120, 100%, 40%);">+            else</span><br><span style="color: hsl(120, 100%, 40%);">+                  printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx "</span><br><span style="color: hsl(120, 100%, 40%);">+                             "not assigned\n", dev_path(dev), resource->index,</span><br><span style="color: hsl(120, 100%, 40%);">+                        resource_type(resource), resource->size);</span><br><span>          return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27668">change 27668</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27668"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8da01cd462225b633bf2043ab33b35aeddc8d55a </div>
<div style="display:none"> Gerrit-Change-Number: 27668 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>