<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27648">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/ite/it8720f: fix power control init<br><br>Change-Id: I3c26a2837e451dbfd3cee82e9beedc0f4a90af03<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/superio/ite/it8720f/it8720f.h<br>M src/superio/ite/it8720f/superio.c<br>2 files changed, 21 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/27648/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/ite/it8720f/it8720f.h b/src/superio/ite/it8720f/it8720f.h</span><br><span>index f8b7efb..093e895 100644</span><br><span>--- a/src/superio/ite/it8720f/it8720f.h</span><br><span>+++ b/src/superio/ite/it8720f/it8720f.h</span><br><span>@@ -30,4 +30,8 @@</span><br><span> #define IT8720F_GPIO 0x07 /* GPIO (including SPI flash interface) */</span><br><span> #define IT8720F_CIR  0x0a /* Consumer IR */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Registers in LDNs */</span><br><span style="color: hsl(120, 100%, 40%);">+#define IT8720F_EC_PCR1       0xf2</span><br><span style="color: hsl(120, 100%, 40%);">+#define IT8720F_EC_PCR2   0xf4</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* SUPERIO_ITE_IT8720F_H */</span><br><span>diff --git a/src/superio/ite/it8720f/superio.c b/src/superio/ite/it8720f/superio.c</span><br><span>index 142686e..b3e5222 100644</span><br><span>--- a/src/superio/ite/it8720f/superio.c</span><br><span>+++ b/src/superio/ite/it8720f/superio.c</span><br><span>@@ -33,17 +33,27 @@</span><br><span> static void power_control_init(struct device *dev)</span><br><span> {</span><br><span>       int power_on = MAINBOARD_POWER_OFF;</span><br><span style="color: hsl(0, 100%, 40%);">-     u8 addr, value;</span><br><span style="color: hsl(120, 100%, 40%);">+       u8 value;</span><br><span> </span><br><span>        get_option(&power_on, "power_on_after_fail");</span><br><span style="color: hsl(0, 100%, 40%);">-     if (power_on == MAINBOARD_POWER_OFF)</span><br><span style="color: hsl(0, 100%, 40%);">-            return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    pnp_enter_conf_mode(dev);</span><br><span>    pnp_set_logical_device(dev);</span><br><span style="color: hsl(0, 100%, 40%);">-    addr = power_on == MAINBOARD_POWER_KEEP ? 0xf2 : 0xf4;</span><br><span style="color: hsl(0, 100%, 40%);">-  value = pnp_read_config(dev, addr);</span><br><span style="color: hsl(0, 100%, 40%);">-     value |= BIT(5);</span><br><span style="color: hsl(0, 100%, 40%);">-        pnp_write_config(dev, addr, value);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ value = pnp_read_config(dev, IT8720F_EC_PCR1);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (power_on == MAINBOARD_POWER_KEEP)</span><br><span style="color: hsl(120, 100%, 40%);">+         value |= (1<<5);</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span style="color: hsl(120, 100%, 40%);">+          value &= ~(1<<5);</span><br><span style="color: hsl(120, 100%, 40%);">+   pnp_write_config(dev, IT8720F_EC_PCR1, value);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      value = pnp_read_config(dev, IT8720F_EC_PCR2);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (power_on == MAINBOARD_POWER_ON)</span><br><span style="color: hsl(120, 100%, 40%);">+           value |= (1<<5);</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span style="color: hsl(120, 100%, 40%);">+          value &= ~(1<<5);</span><br><span style="color: hsl(120, 100%, 40%);">+   pnp_write_config(dev, IT8720F_EC_PCR2, value);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     pnp_exit_conf_mode(dev);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27648">change 27648</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27648"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3c26a2837e451dbfd3cee82e9beedc0f4a90af03 </div>
<div style="display:none"> Gerrit-Change-Number: 27648 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>