<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27643">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge: Use multiple VBIOS images<br><br>The careena board required a different setting within VBIOS in order to<br>pass eDP eye diagram test, creating the possibility that different boards<br>might need different VBIOS images. Prepare the framework for multiple VBIOS<br>images, use the newer VBIOS for all grunt variants (until a new board needs<br>something different) while maintaining the original one for gardenia.<br><br>BUG=b:111673328<br>TEST=Change VBIOS_015_049_000_017.bin name, build grunt, fails. Return<br>original name, build grunt, success.<br><br>Change-Id: I268cd3dbce6ba1f7bd781d768f470463846a4e10<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M 3rdparty/blobs<br>M src/mainboard/amd/gardenia/Kconfig<br>M src/mainboard/google/kahlee/Kconfig<br>M src/soc/amd/stoneyridge/Kconfig<br>4 files changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/27643/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/3rdparty/blobs b/3rdparty/blobs</span><br><span>index 3854ad2..4f466ab 160000</span><br><span>--- a/3rdparty/blobs</span><br><span>+++ b/3rdparty/blobs</span><br><span>@@ -1 +1 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Subproject commit 3854ad29e7b767001d4f6dd93eba0d79aedda9c3</span><br><span style="color: hsl(120, 100%, 40%);">+Subproject commit 4f466ab06f44a1fc3c5ac42fecd8232b7f28b872</span><br><span>diff --git a/src/mainboard/amd/gardenia/Kconfig b/src/mainboard/amd/gardenia/Kconfig</span><br><span>index 5d74768..091fad1 100644</span><br><span>--- a/src/mainboard/amd/gardenia/Kconfig</span><br><span>+++ b/src/mainboard/amd/gardenia/Kconfig</span><br><span>@@ -49,4 +49,8 @@</span><br><span> bool</span><br><span> default y</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config VGA_BIOS_FILE_BLOB</span><br><span style="color: hsl(120, 100%, 40%);">+ string</span><br><span style="color: hsl(120, 100%, 40%);">+ default "soc/amd/stoneyridge/VBIOS.bin"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> endif # BOARD_AMD_GARDENIA</span><br><span>diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig</span><br><span>index 11cb891..d00fd92 100644</span><br><span>--- a/src/mainboard/google/kahlee/Kconfig</span><br><span>+++ b/src/mainboard/google/kahlee/Kconfig</span><br><span>@@ -51,6 +51,10 @@</span><br><span> string</span><br><span> default google/kahlee</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config VGA_BIOS_FILE_BLOB</span><br><span style="color: hsl(120, 100%, 40%);">+ string</span><br><span style="color: hsl(120, 100%, 40%);">+ default "mainboard/google/kahlee/VBIOS_015_049_000_017.bin"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config VARIANT_DIR</span><br><span> string</span><br><span> default "aleena" if BOARD_GOOGLE_ALEENA</span><br><span>diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig</span><br><span>index 05c3043..363eec4 100644</span><br><span>--- a/src/soc/amd/stoneyridge/Kconfig</span><br><span>+++ b/src/soc/amd/stoneyridge/Kconfig</span><br><span>@@ -137,7 +137,7 @@</span><br><span> </span><br><span> config VGA_BIOS_FILE</span><br><span> string</span><br><span style="color: hsl(0, 100%, 40%);">- default "3rdparty/blobs/soc/amd/stoneyridge/VBIOS.bin"</span><br><span style="color: hsl(120, 100%, 40%);">+ default "3rdparty/blobs/$(VGA_BIOS_FILE_BLOB)"</span><br><span> </span><br><span> config S3_VGA_ROM_RUN</span><br><span> bool</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27643">change 27643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27643"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I268cd3dbce6ba1f7bd781d768f470463846a4e10 </div>
<div style="display:none"> Gerrit-Change-Number: 27643 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>