<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27626">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/caroline: Add missing audio codec info<br><br>Add audio codec definitions in devicetree, which were accidentally<br>dropped when upstreaming<br><br>Test: build/boot Caroline with GalliumOS 3.0a2, verify working audio.<br><br>Change-Id: I707b93c83f773cde2108b75ec550a15e5566d974<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/glados/variants/caroline/devicetree.cb<br>1 file changed, 35 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27626/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>index 9ada5c5..a040714 100644</span><br><span>--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>@@ -226,7 +226,41 @@</span><br><span>           device pci 17.0 off end # SATA</span><br><span>               device pci 19.0 on  end # UART #2</span><br><span>            device pci 19.1 off end # I2C #5</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 19.2 on  end # I2C #4</span><br><span style="color: hsl(120, 100%, 40%);">+              device pci 19.2 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/i2c/nau8825</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F10_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "jkdet_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "jkdet_pull_enable" = "0"   # R389</span><br><span style="color: hsl(120, 100%, 40%);">+                               register "jkdet_polarity" = "1"      # ActiveLow</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "vref_impedance" = "2"      # 125kOhm</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "micbias_voltage" = "6"     # 2.754</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_threshold_num" = "4"</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "sar_threshold[0]" = "0x0c"</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_threshold[1]" = "0x1c"</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_threshold[2]" = "0x38"</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_threshold[3]" = "0x60"</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_hysteresis" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "sar_voltage" = "0"          # VDDA</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "sar_compare_time" = "0"     # 500ns</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "sar_sampling_time" = "0"    # 2us</span><br><span style="color: hsl(120, 100%, 40%);">+                               register "short_key_debounce" = "2"   # 100ms</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "jack_insert_debounce" = "7" # 512ms</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "jack_eject_debounce" = "7"  # 512ms</span><br><span style="color: hsl(120, 100%, 40%);">+                             device i2c 1a on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+                   chip drivers/i2c/generic</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "hid" = ""INT343B""</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "desc" = ""SSM4567 Left Speaker Amp""</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "uid" = "0"</span><br><span style="color: hsl(120, 100%, 40%);">+                              device i2c 34 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+                   chip drivers/i2c/generic</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "hid" = ""INT343B""</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "desc" = ""SSM4567 Right Speaker Amp""</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "uid" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                              device i2c 35 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # I2C #4</span><br><span>                 device pci 1c.0 on</span><br><span>                   chip drivers/intel/wifi</span><br><span>                              register "wake" = "GPE0_DW0_16"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27626">change 27626</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27626"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I707b93c83f773cde2108b75ec550a15e5566d974 </div>
<div style="display:none"> Gerrit-Change-Number: 27626 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>