<p>Matt Delco has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27605">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/nocturne: simplify camera power references<br><br>This change primarily moves the PowerResource up to a more<br>common scope so that the _PRx references are simpler<br>(the ^ scope modifier isn't well supported everywhere<br>amongst OSes and drivers, and I've got an OS that can't<br>boot with the way things are currently laid out).<br><br>I've also not seen a firmware outside of coreboot that tries<br>to reference count _ON and _OFF. Isn't it up to the OS to<br>deference count, and whatever it tells ACPI is what should<br>happen (i.e., on means on and off means off)? I could do<br>basic comparison for 1 and 0 but LEqual seems to be what<br>other firmwares use (I presume to permit subsequent attempts<br>at _OFF to affect potentially problematic hardware).<br><br>Some of the _UIDs are also duplicated, so I've made them unique.<br><br>A few cosmetic changes were made so that diffing cam0.asl<br>against cam1.asl has fewer extraneous differences.<br><br>Change-Id: I9c9f6c712b075450539d5b84ac5bb221b3cbb57e<br>Signed-off-by: Matt Delco <delco@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl<br>2 files changed, 88 insertions(+), 123 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/27605/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>index 27f1275..ec4430d 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>@@ -15,6 +15,42 @@</span><br><span> </span><br><span> Scope (\_SB.PCI0.I2C3)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (FCPR, 0, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(STA, 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep (3)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * A delay of T7 (minimum of 5 ms) + T8</span><br><span style="color: hsl(120, 100%, 40%);">+ * (max 5 ms + delay of coarse integration</span><br><span style="color: hsl(120, 100%, 40%);">+ * time value + 14 H, time for 14 horizontal</span><br><span style="color: hsl(120, 100%, 40%);">+ * lines) is needed to have the sensor ready</span><br><span style="color: hsl(120, 100%, 40%);">+ * for streaming, as soon as the power on</span><br><span style="color: hsl(120, 100%, 40%);">+ * sequence completes</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep (11)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (1, STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(STA, 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (0, STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Device (CAM0)</span><br><span> {</span><br><span> Name (_HID, "SONY319A") /* _HID: Hardware ID */</span><br><span>@@ -29,65 +65,13 @@</span><br><span> Name (_CRS, ResourceTemplate ()</span><br><span> {</span><br><span> I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (STA, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method (PMON, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(3)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * A delay of T7 (minimum of 5 ms) + T8</span><br><span style="color: hsl(0, 100%, 40%);">- * (max 5 ms + delay of coarse integration</span><br><span style="color: hsl(0, 100%, 40%);">- * time value + 14 H, time for 14 horizontal</span><br><span style="color: hsl(0, 100%, 40%);">- * lines) is needed to have the sensor ready</span><br><span style="color: hsl(0, 100%, 40%);">- * for streaming, as soon as the power on</span><br><span style="color: hsl(0, 100%, 40%);">- * sequence completes</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(11);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- STA++</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Method (PMOF, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- STA--</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(0, 100%, 40%);">- PowerResource (FCPR, 0, 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- PMON ()</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- PMOF ()</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_STA, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreater(STA,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x1)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Else {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x0)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package () { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package () { FCPR })</span><br><span> </span><br><span> /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span> Name (_DSD, Package () {</span><br><span>@@ -147,11 +131,10 @@</span><br><span> AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span> 0x00, ResourceConsumer, ,)</span><br><span> })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package () { CAM0 })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package() { ^^I2C3.CAM0 })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package () { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package () { FCPR })</span><br><span> </span><br><span> Name (_DSD, Package ()</span><br><span> {</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>index ca2fee4..19146dc 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>@@ -15,6 +15,40 @@</span><br><span> </span><br><span> Scope (\_SB.PCI0.I2C5)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (RCPR, 0, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(STA, 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep (3)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * A delay of T7 (minimum of 10 ms) + T8</span><br><span style="color: hsl(120, 100%, 40%);">+ * (max 1.4 ms + delay of coarse integration</span><br><span style="color: hsl(120, 100%, 40%);">+ * time value) is needed to have the sensor</span><br><span style="color: hsl(120, 100%, 40%);">+ * ready for streaming, as soon as the power</span><br><span style="color: hsl(120, 100%, 40%);">+ * on sequence completes</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep (12)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (1, STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual(STA, 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Store (0, STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (STA)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> Device (CAM1)</span><br><span> {</span><br><span>@@ -35,59 +69,8 @@</span><br><span> )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (STA, 0)</span><br><span style="color: hsl(0, 100%, 40%);">- Method (PMON, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(3)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /*</span><br><span style="color: hsl(0, 100%, 40%);">- * A delay of T7 (minimum of 10 ms) + T8</span><br><span style="color: hsl(0, 100%, 40%);">- * (max 1.4 ms + delay of coarse integration</span><br><span style="color: hsl(0, 100%, 40%);">- * time value) is needed to have the sensor</span><br><span style="color: hsl(0, 100%, 40%);">- * ready for streaming, as soon as the power</span><br><span style="color: hsl(0, 100%, 40%);">- * on sequence completes</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(12)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- STA++</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Method (PMOF, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- STA--</span><br><span style="color: hsl(0, 100%, 40%);">- If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(0, 100%, 40%);">- PowerResource (RCPR, 0, 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- PMON ()</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- PMOF ()</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_STA, 0, Serialized) {</span><br><span style="color: hsl(0, 100%, 40%);">- If (LGreater(STA,0)) {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x1)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- Else {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x0)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span> /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span> Name (_DSD, Package () {</span><br><span>@@ -136,7 +119,7 @@</span><br><span> Device (VCM1)</span><br><span> {</span><br><span> Name (_HID, "PRP0001") /* _HID: Hardware ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, 3) /* _UID: Unique ID */</span><br><span> Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */</span><br><span> </span><br><span> Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span>@@ -152,10 +135,10 @@</span><br><span> )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package() { ^^I2C5.CAM1 })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package() { CAM1 })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span> Name (_DSD, Package () {</span><br><span> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span>@@ -168,7 +151,7 @@</span><br><span> Device (NVM1)</span><br><span> {</span><br><span> Name (_HID, "INT3499") /* _HID: Hardware ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, 1) /* _UID: Unique ID */</span><br><span> Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */</span><br><span> </span><br><span> Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span>@@ -182,11 +165,10 @@</span><br><span> AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span> 0x00, ResourceConsumer, ,)</span><br><span> })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package () { CAM1 })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package () { ^^I2C5.CAM1 })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span> Name (_DSD, Package ()</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27605">change 27605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27605"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9c9f6c712b075450539d5b84ac5bb221b3cbb57e </div>
<div style="display:none"> Gerrit-Change-Number: 27605 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>