<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">+Rajmohan, +Tomasz to comment on the reference count and how the kernel driver is handling it.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Looking at the linux kernel side of implementation: https://github.com/torvalds/linux/blob/master/drivers/acpi/power.c#L280, I agree with Matt, that this is already handled by acpi_power_off_unlocked to ensure that the power resource doesn't get turned off before its refcount drops to 0. So, the check in coreboot ACPI table seems redundant.</p><p><a href="https://review.coreboot.org/27605">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://review.coreboot.org/27605">change 27605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9c9f6c712b075450539d5b84ac5bb221b3cbb57e </div>
<div style="display:none"> Gerrit-Change-Number: 27605 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>
<div style="display:none"> Gerrit-Assignee: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Tomasz Figa <tfiga@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 23 Jul 2018 18:00:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>