<p>Matt Delco has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27612">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lib/nhlt: add missing size field<br><br>coreboot doesn't provide a field that's required by some drivers.<br>This doc is apparently offline:<br><br>https://01.org/blogs/2016/intel-smart-sound-technology-audio-dsp<br><br>but can currently be found at:<br><br>https://docplayer.net/36738126-Intel-smart-sound-technology-audio-<br>dsp-non-hd-audio-acpi-high-level-design.html<br><br>Figure 2-1 (page 9) shows a SPECIFIC_CONFIG struct that<br>should follow the endpoint descriptors.  The struct is described in<br>section 2.2 (page 10).  It's sufficient to just provide the<br>"CapabilitiesSize" field that's set to zero (meaning no<br>capabilities follow).<br><br>Change-Id: Ic0480c8123225a49c23b9e6af44ee20072c57a3f<br>Signed-off-by: Matt Delco <delco@chromium.org><br>---<br>M src/lib/nhlt.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/27612/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/lib/nhlt.c b/src/lib/nhlt.c</span><br><span>index f6135c7..876d97d 100644</span><br><span>--- a/src/lib/nhlt.c</span><br><span>+++ b/src/lib/nhlt.c</span><br><span>@@ -276,7 +276,7 @@</span><br><span> </span><br><span> size_t nhlt_current_size(struct nhlt *nhlt)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      return calc_size(nhlt) + sizeof(acpi_header_t);</span><br><span style="color: hsl(120, 100%, 40%);">+       return calc_size(nhlt) + sizeof(acpi_header_t) + sizeof(uint32_t);</span><br><span> }</span><br><span> </span><br><span> static void nhlt_free_resources(struct nhlt *nhlt)</span><br><span>@@ -387,6 +387,7 @@</span><br><span> </span><br><span>  for (i = 0; i < nhlt->num_endpoints; i++)</span><br><span>              serialize_endpoint(&nhlt->endpoints[i], cur);</span><br><span style="color: hsl(120, 100%, 40%);">+  ser32(cur, 0); /* size of "Capabilities" buffer that follows (i.e., none) */</span><br><span> }</span><br><span> </span><br><span> uintptr_t nhlt_serialize(struct nhlt *nhlt, uintptr_t acpi_addr)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27612">change 27612</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27612"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic0480c8123225a49c23b9e6af44ee20072c57a3f </div>
<div style="display:none"> Gerrit-Change-Number: 27612 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>