<p><a href="https://review.coreboot.org/27561">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27561/2/src/drivers/i2c/da7219/da7219.c">File src/drivers/i2c/da7219/da7219.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27561/2/src/drivers/i2c/da7219/da7219.c@87">Patch Set #2, Line 87:</a> <code style="font-family:monospace,monospace">acpi_dp_add_integer(dsd, "dlg,vddio", config->vddio);</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Shouldn't this be done after ensuring vddio is non-zero:<br>if (config->vddio)<br> ...</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27561">change 27561</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27561"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I87ff6e22e2d38e984a8fd7f8434e3f55fd3def24 </div>
<div style="display:none"> Gerrit-Change-Number: 27561 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal@amd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 21 Jul 2018 05:03:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>