<p><a href="https://review.coreboot.org/27483">View Change</a></p><p>51 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/qcom-geni-se.h">File src/soc/qualcomm/sdm845/include/soc/qcom-geni-se.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/qcom-geni-se.h@75">Patch Set #3, Line 75:</a> <code style="font-family:monospace,monospace"> (((0xFFFFFFFF) - (1UL << (l)) + 1) & (0xFFFFFFFF >> (BITS_PER_LONG - 1 - (h))))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h">File src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h@26">Patch Set #3, Line 26:</a> <code style="font-family:monospace,monospace">}irq_status_t;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h@29">Patch Set #3, Line 29:</a> <code style="font-family:monospace,monospace"> u8* phys_addr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h@48">Patch Set #3, Line 48:</a> <code style="font-family:monospace,monospace"> u8 *rx_buf;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/include/soc/spi-geni-qcom.h@49">Patch Set #3, Line 49:</a> <code style="font-family:monospace,monospace"> u8 *tx_buf;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c">File src/soc/qualcomm/sdm845/spi_qup.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@28">Patch Set #3, Line 28:</a> <code style="font-family:monospace,monospace">//helper funtions</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'funtions' may be misspelled - perhaps 'functions'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@110">Patch Set #3, Line 110:</a> <code style="font-family:monospace,monospace">#define min(x, y) ( { \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@117">Patch Set #3, Line 117:</a> <code style="font-family:monospace,monospace">#define IRQ_TRIGGER (M_RX_FIFO_WATERMARK_EN | M_RX_FIFO_LAST_EN | M_TX_FIFO_WATERMARK_EN \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@118">Patch Set #3, Line 118:</a> <code style="font-family:monospace,monospace"> | M_CMD_DONE_EN | M_CMD_CANCEL_EN | M_CMD_ABORT_EN)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@125">Patch Set #3, Line 125:</a> <code style="font-family:monospace,monospace"> #define REG_OUT(base, offset, value) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@148">Patch Set #3, Line 148:</a> <code style="font-family:monospace,monospace"> u8 * reg = base + offset;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@148">Patch Set #3, Line 148:</a> <code style="font-family:monospace,monospace"> u8 * reg = base + offset;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo * bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@149">Patch Set #3, Line 149:</a> <code style="font-family:monospace,monospace"> return *(volatile uint32_t *)(reg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@161">Patch Set #3, Line 161:</a> <code style="font-family:monospace,monospace"> (*(volatile uint32_t *)(base + offset) = (value));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@163">Patch Set #3, Line 163:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">void function return statements are not generally useful</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@418">Patch Set #3, Line 418:</a> <code style="font-family:monospace,monospace"> // & SPI_CS_CLK_DELAY_MSK;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@436">Patch Set #3, Line 436:</a> <code style="font-family:monospace,monospace"> idx=1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@437">Patch Set #3, Line 437:</a> <code style="font-family:monospace,monospace"> div=2;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@439">Patch Set #3, Line 439:</a> <code style="font-family:monospace,monospace"> mode =(slave_cfg->clk_polarity|slave_cfg->clk_phase);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:WxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@448">Patch Set #3, Line 448:</a> <code style="font-family:monospace,monospace"> geni_write_reg(demux_output_inv, spi_bus->phys_addr, SE_SPI_DEMUX_OUTPUT_INV);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@451">Patch Set #3, Line 451:</a> <code style="font-family:monospace,monospace"> geni_write_reg(spi_delay_params, spi_bus->phys_addr, SE_SPI_DELAY_COUNTERS);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@534">Patch Set #3, Line 534:</a> <code style="font-family:monospace,monospace"> if (!mas->tx_rem_bytes) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@544">Patch Set #3, Line 544:</a> <code style="font-family:monospace,monospace"> u32 rx_fifo_status = geni_read_reg(mas->phys_addr, SE_GENI_RX_FIFO_STATUS);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@614">Patch Set #3, Line 614:</a> <code style="font-family:monospace,monospace"> geni_write_reg(0, mas->phys_addr, SE_GENI_TX_WATERMARK_REG);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@617">Patch Set #3, Line 617:</a> <code style="font-family:monospace,monospace"> if (mas->rx_rem_bytes)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 16)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@629">Patch Set #3, Line 629:</a> <code style="font-family:monospace,monospace"> int max_delay=MAX_DELAY_STEP;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@636">Patch Set #3, Line 636:</a> <code style="font-family:monospace,monospace"> }while(max_delay > 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@636">Patch Set #3, Line 636:</a> <code style="font-family:monospace,monospace"> }while(max_delay > 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@646">Patch Set #3, Line 646:</a> <code style="font-family:monospace,monospace"> geni_write_reg(M_GENI_CMD_CANCEL, mas->phys_addr, SE_GENI_M_CMD_CTRL_REG);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@650">Patch Set #3, Line 650:</a> <code style="font-family:monospace,monospace"> geni_write_reg(M_GENI_CMD_ABORT, mas->phys_addr, SE_GENI_M_CMD_CTRL_REG);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@659">Patch Set #3, Line 659:</a> <code style="font-family:monospace,monospace"> struct spi_geni_master *spi_bus = to_spi_geni_master(slave);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@665">Patch Set #3, Line 665:</a> <code style="font-family:monospace,monospace"> int bytes_per_word=0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@667">Patch Set #3, Line 667:</a> <code style="font-family:monospace,monospace"> spi_bus->num_xfers = 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@668">Patch Set #3, Line 668:</a> <code style="font-family:monospace,monospace"> spi_bus->size = bytes_out > bytes_in ? bytes_out : bytes_in;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@669">Patch Set #3, Line 669:</a> <code style="font-family:monospace,monospace"> spi_bus->tx_buf = (u8 *)dout;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@670">Patch Set #3, Line 670:</a> <code style="font-family:monospace,monospace"> spi_bus->rx_buf = (u8 *)din;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@671">Patch Set #3, Line 671:</a> <code style="font-family:monospace,monospace"> spi_bus->tx_rem_bytes = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@683">Patch Set #3, Line 683:</a> <code style="font-family:monospace,monospace"> if (!(spi_bus->cur_word_len % MIN_WORD_LEN)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@683">Patch Set #3, Line 683:</a> <code style="font-family:monospace,monospace"> if (!(spi_bus->cur_word_len % MIN_WORD_LEN)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (4, 16)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@685">Patch Set #3, Line 685:</a> <code style="font-family:monospace,monospace"> ((spi_bus->size << 3) / spi_bus->cur_word_len) & TRANS_LEN_MSK;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@694">Patch Set #3, Line 694:</a> <code style="font-family:monospace,monospace"> geni_write_reg(trans_len, spi_bus->phys_addr, SE_SPI_TX_TRANS_LEN);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@698">Patch Set #3, Line 698:</a> <code style="font-family:monospace,monospace"> geni_write_reg(trans_len, spi_bus->phys_addr, SE_SPI_RX_TRANS_LEN);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@701">Patch Set #3, Line 701:</a> <code style="font-family:monospace,monospace"> geni_setup_m_cmd(spi_bus->phys_addr, m_cmd, m_param);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@704">Patch Set #3, Line 704:</a> <code style="font-family:monospace,monospace"> geni_write_reg(spi_bus->tx_wm, spi_bus->phys_addr, SE_GENI_TX_WATERMARK_REG);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@711">Patch Set #3, Line 711:</a> <code style="font-family:monospace,monospace"> else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else should follow close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@723">Patch Set #3, Line 723:</a> <code style="font-family:monospace,monospace"> spi_bus->phys_addr = (u8 *)0x880000;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@724">Patch Set #3, Line 724:</a> <code style="font-family:monospace,monospace"> u8* spi_bus_base = spi_bus->phys_addr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@724">Patch Set #3, Line 724:</a> <code style="font-family:monospace,monospace"> u8* spi_bus_base = spi_bus->phys_addr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@733">Patch Set #3, Line 733:</a> <code style="font-family:monospace,monospace"> /*TODO :slave_cfg Should be set by client before xfer, initializing default values*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@734">Patch Set #3, Line 734:</a> <code style="font-family:monospace,monospace"> spi_bus->slave_cfg = (struct spi_cfg) {SPI_CLOCK_PHASE_FIRST, SPI_POLARITY_LOW, SPI_POLARITY_LOW, SPI_4_WIRE_MODE, 0x8};</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27483/3/src/soc/qualcomm/sdm845/spi_qup.c@758">Patch Set #3, Line 758:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">void function return statements are not generally useful</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27483">change 27483</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27483"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54 </div>
<div style="display:none"> Gerrit-Change-Number: 27483 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: T.Michael Turney <tturne@codeaurora.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: T Michael Turney <mturney@codeaurora.org> </div>
<div style="display:none"> Gerrit-Reviewer: Vin Kamath <vink@codeaurora.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 20 Jul 2018 22:17:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>