<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27550">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/glados: use level trigger for touchpad interrupt<br><br>Coolstar's custom touchpad drivers for Windows require level triggering,<br>and the Linux drivers don't care/perform identically either way. Set<br>touchpad interrupt to level trigger, matching change made to other<br>Chromebooks.<br><br>Test: boot Windows 10 on google/chell, verify touchpad functional<br><br>Change-Id: Id5f145b8b24c04f9c6661710a0cda95f135293e9<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/glados/variants/asuka/devicetree.cb<br>M src/mainboard/google/glados/variants/caroline/devicetree.cb<br>M src/mainboard/google/glados/variants/cave/devicetree.cb<br>M src/mainboard/google/glados/variants/chell/devicetree.cb<br>M src/mainboard/google/glados/variants/glados/devicetree.cb<br>M src/mainboard/google/glados/variants/lars/devicetree.cb<br>M src/mainboard/google/glados/variants/sentry/devicetree.cb<br>7 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/27550/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/glados/variants/asuka/devicetree.cb b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>index b014025..b9e87a8 100644</span><br><span>--- a/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>@@ -203,7 +203,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>index e6bf073..9ada5c5 100644</span><br><span>--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>@@ -211,7 +211,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ATML0000""</span><br><span> register "desc" = ""Atmel Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 4a on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/cave/devicetree.cb b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>index 91c7b71..f512f9b 100644</span><br><span>--- a/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>@@ -218,7 +218,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/chell/devicetree.cb b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>index b363ad8..3343aa0 100644</span><br><span>--- a/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>@@ -207,7 +207,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/glados/devicetree.cb b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>index 2c210fe..2472dde 100644</span><br><span>--- a/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>@@ -212,7 +212,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/lars/devicetree.cb b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>index daf886c..d552010 100644</span><br><span>--- a/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>@@ -200,7 +200,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span>diff --git a/src/mainboard/google/glados/variants/sentry/devicetree.cb b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>index 7ff110e..7a89194 100644</span><br><span>--- a/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>@@ -209,7 +209,7 @@</span><br><span> chip drivers/i2c/generic</span><br><span> register "hid" = ""ELAN0000""</span><br><span> register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span> register "wake" = "GPE0_DW0_05"</span><br><span> device i2c 15 on end</span><br><span> end</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27550">change 27550</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27550"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id5f145b8b24c04f9c6661710a0cda95f135293e9 </div>
<div style="display:none"> Gerrit-Change-Number: 27550 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>