<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27549">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/glados: enable VMX for all variants<br><br>Explicitly enable VMX, as some OSes (eg, Windows) need VMX<br>feature enabled and locked in order to fully support virtualization<br><br>Test: boot Windows 10 on google/chell, verify OS reports virtualization<br>enabled<br><br>Change-Id: I53ff575755a9ca376dbf953db96191c17bf57f5f<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/glados/variants/asuka/devicetree.cb<br>M src/mainboard/google/glados/variants/caroline/devicetree.cb<br>M src/mainboard/google/glados/variants/cave/devicetree.cb<br>M src/mainboard/google/glados/variants/chell/devicetree.cb<br>M src/mainboard/google/glados/variants/glados/devicetree.cb<br>M src/mainboard/google/glados/variants/lars/devicetree.cb<br>M src/mainboard/google/glados/variants/sentry/devicetree.cb<br>7 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/27549/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/glados/variants/asuka/devicetree.cb b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>index cbd8b01..b014025 100644</span><br><span>--- a/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/asuka/devicetree.cb</span><br><span>@@ -44,6 +44,7 @@</span><br><span>      register "PmConfigSlpSusMinAssert" = "3"       # 4s</span><br><span>      register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>index f892187..e6bf073 100644</span><br><span>--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb</span><br><span>@@ -54,6 +54,7 @@</span><br><span>      register "PmConfigSlpSusMinAssert" = "1"       # 500ms</span><br><span>   register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   # TCC offset</span><br><span>         register "tcc_offset" = "10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/cave/devicetree.cb b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>index 02667a4..91c7b71 100644</span><br><span>--- a/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/cave/devicetree.cb</span><br><span>@@ -54,6 +54,7 @@</span><br><span>        register "PmConfigSlpSusMinAssert" = "1"       # 500ms</span><br><span>   register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/chell/devicetree.cb b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>index b9d072f..b363ad8 100644</span><br><span>--- a/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/chell/devicetree.cb</span><br><span>@@ -54,6 +54,7 @@</span><br><span>  register "PmConfigSlpSusMinAssert" = "1"       # 500ms</span><br><span>   register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/glados/devicetree.cb b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>index 75e116c..2c210fe 100644</span><br><span>--- a/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/glados/devicetree.cb</span><br><span>@@ -54,6 +54,7 @@</span><br><span>      register "PmConfigSlpSusMinAssert" = "1"       # 500ms</span><br><span>   register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/lars/devicetree.cb b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>index 2eda59b..daf886c 100644</span><br><span>--- a/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/lars/devicetree.cb</span><br><span>@@ -42,6 +42,7 @@</span><br><span>      register "PmConfigSlpSusMinAssert" = "3"       # 4s</span><br><span>      register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span>diff --git a/src/mainboard/google/glados/variants/sentry/devicetree.cb b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>index 8af8940..7ff110e 100644</span><br><span>--- a/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>+++ b/src/mainboard/google/glados/variants/sentry/devicetree.cb</span><br><span>@@ -44,6 +44,7 @@</span><br><span>      register "PmConfigSlpSusMinAssert" = "3"       # 4s</span><br><span>      register "PmConfigSlpAMinAssert" = "3"         # 2s</span><br><span>      register "PmTimerDisabled" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+  register "VmxEnable" = "1"</span><br><span> </span><br><span>   register "pirqa_routing" = "PCH_IRQ11"</span><br><span>   register "pirqb_routing" = "PCH_IRQ10"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27549">change 27549</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27549"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I53ff575755a9ca376dbf953db96191c17bf57f5f </div>
<div style="display:none"> Gerrit-Change-Number: 27549 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>