<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27534">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/gitconfig: Make checkpatch non fatal in pre-commit hook<br><br>We don't block commits for failing checkpatch in gerrit, and we<br>shouldn't block them here.  This allows checkpatch to still run, so<br>users can see the issues, but won't prevent the commit.<br><br>Adds a delay if checkpatch fails so that the issues can be seen.<br><br>Change-Id: Ibd4e8bb74e0b02825dcdf16e233a061c4bb43f50<br>Signed-off-by: Martin Roth <martin@coreboot.org><br>---<br>M util/gitconfig/pre-commit<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27534/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit</span><br><span>index 027eec0..0644b7f 100755</span><br><span>--- a/util/gitconfig/pre-commit</span><br><span>+++ b/util/gitconfig/pre-commit</span><br><span>@@ -24,5 +24,6 @@</span><br><span> if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then</span><br><span>         echo</span><br><span>         echo "Running checkpatch"</span><br><span style="color: hsl(0, 100%, 40%);">-     printf "%s\n" "$PATCHDIFF" | util/lint/lint-007-checkpatch diff</span><br><span style="color: hsl(120, 100%, 40%);">+   printf "%s\n" "$PATCHDIFF" | util/lint/lint-007-checkpatch diff \</span><br><span style="color: hsl(120, 100%, 40%);">+         || (echo "Please consider fixing these issues." ;sleep 5) ; true</span><br><span> fi</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27534">change 27534</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27534"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibd4e8bb74e0b02825dcdf16e233a061c4bb43f50 </div>
<div style="display:none"> Gerrit-Change-Number: 27534 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>