<p><a href="https://review.coreboot.org/27419">View Change</a></p><p>15 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h">File src/mainboard/google/glados/variants/caroline/include/variant/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@79">Patch Set #4, Line 79:</a> <code style="font-family:monospace,monospace">/* PIRQA# */                PAD_CFG_GPI_GPIO_DRIVER(GPP_A7, 20K_PU, DEEP), /* SD_CD_INT_L */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@101">Patch Set #4, Line 101:</a> <code style="font-family:monospace,monospace">/* SRCCLKREQ0# */     PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@111">Patch Set #4, Line 111:</a> <code style="font-family:monospace,monospace">/* GSPI0_CS# */             PAD_CFG_GPI_ACPI_SCI(GPP_B15, NONE, DEEP, NONE), /* DIG EJECT */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@112">Patch Set #4, Line 112:</a> <code style="font-family:monospace,monospace">/* GSPI0_CLK */               PAD_CFG_GPI_ACPI_SCI(GPP_B16, NONE, DEEP, YES), /* WLAN WAKE */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@115">Patch Set #4, Line 115:</a> <code style="font-family:monospace,monospace">/* GSPI1_CS# */                PAD_CFG_GPI_GPIO_DRIVER(GPP_B19, NONE, DEEP), /* non-wake DIG EJECT */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@126">Patch Set #4, Line 126:</a> <code style="font-family:monospace,monospace">/* SM1CLK */            PAD_CFG_GPI_GPIO_DRIVER(GPP_C6, 20K_PU, DEEP), /* EC_IN_RW */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@132">Patch Set #4, Line 132:</a> <code style="font-family:monospace,monospace">/* UART1_RXD */          PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), /* MEM_CONFIG[0] */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@133">Patch Set #4, Line 133:</a> <code style="font-family:monospace,monospace">/* UART1_TXD */              PAD_CFG_GPI_GPIO_DRIVER(GPP_C13, NONE, DEEP), /* MEM_CONFIG[1] */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@134">Patch Set #4, Line 134:</a> <code style="font-family:monospace,monospace">/* UART1_RTS# */     PAD_CFG_GPI_GPIO_DRIVER(GPP_C14, NONE, DEEP), /* MEM_CONFIG[2] */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@135">Patch Set #4, Line 135:</a> <code style="font-family:monospace,monospace">/* UART1_CTS# */     PAD_CFG_GPI_GPIO_DRIVER(GPP_C15, NONE, DEEP), /* MEM_CONFIG[3] */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@143">Patch Set #4, Line 143:</a> <code style="font-family:monospace,monospace">/* UART2_CTS# */     PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@175">Patch Set #4, Line 175:</a> <code style="font-family:monospace,monospace">/* CPU_GP1 */             PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST), /* TOUCHSCREEN */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@183">Patch Set #4, Line 183:</a> <code style="font-family:monospace,monospace">/* DDPD_HPD2 */              PAD_CFG_GPI_ACPI_SMI(GPP_E15, NONE, DEEP, YES), /* EC_SMI_L */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@184">Patch Set #4, Line 184:</a> <code style="font-family:monospace,monospace">/* DDPE_HPD3 */         PAD_CFG_GPI_ACPI_SCI(GPP_E16, NONE, DEEP, YES), /* EC_SCI_L */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27419/4/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@249">Patch Set #4, Line 249:</a> <code style="font-family:monospace,monospace">/* UART2_CTS# */        PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27419">change 27419</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27419"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I611a4e76581ba2e5b42e1bc48b0a5b8c70f3598e </div>
<div style="display:none"> Gerrit-Change-Number: 27419 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Youness Alaoui <snifikino@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 18 Jul 2018 20:27:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>