<p><a href="https://review.coreboot.org/27518">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/bootblock.c">File src/soc/intel/skylake/bootblock/bootblock.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/bootblock.c@150">Patch Set #1, Line 150:</a> <code style="font-family:monospace,monospace">      pci_write_config32(PCH_DEV_SMBUS, TCOBASE, TCO_BASE_ADDDRESS);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ADDDRESS' may be misspelled - perhaps 'ADDRESS'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27518/1/src/soc/intel/skylake/bootblock/bootblock.c@159">Patch Set #1, Line 159:</a> <code style="font-family:monospace,monospace">       pcr_write32(PID_DMI, PCR_DMI_TCOBASE, TCO_BASE_ADDDRESS | (1 << 1));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ADDDRESS' may be misspelled - perhaps 'ADDRESS'?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27518">change 27518</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27518"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I46cb6bc6f6c6b97243f7d40457fd02d4ef7b8933 </div>
<div style="display:none"> Gerrit-Change-Number: 27518 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Jul 2018 22:31:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>