<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27481">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/x201: Fix EC SSDT<br><br>Move the EC under the LPC PCI device to make sure that the SSDT path<br>matches the DSDT. Matches the behaviour of all other Lenovo devices.<br><br>Change-Id: I9ded7f639866d71d39ea0d5d0c36602d386c177f<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/mainboard/lenovo/x201/devicetree.cb<br>1 file changed, 42 insertions(+), 42 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/27481/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/x201/devicetree.cb b/src/mainboard/lenovo/x201/devicetree.cb</span><br><span>index a1746bd..fa33aeb 100644</span><br><span>--- a/src/mainboard/lenovo/x201/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/x201/devicetree.cb</span><br><span>@@ -36,48 +36,6 @@</span><br><span>        register "gfx.use_spread_spectrum_clock" = "1"</span><br><span>   register "gfx.link_frequency_270_mhz" = "1"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     chip ec/lenovo/pmh7</span><br><span style="color: hsl(0, 100%, 40%);">-             device pnp ff.1 on # dummy</span><br><span style="color: hsl(0, 100%, 40%);">-              end</span><br><span style="color: hsl(0, 100%, 40%);">-             register "backlight_enable" = "0x01"</span><br><span style="color: hsl(0, 100%, 40%);">-                register "dock_event_enable" = "0x01"</span><br><span style="color: hsl(0, 100%, 40%);">-       end</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     chip ec/lenovo/h8</span><br><span style="color: hsl(0, 100%, 40%);">-               device pnp ff.2 on # dummy</span><br><span style="color: hsl(0, 100%, 40%);">-                      io 0x60 = 0x62</span><br><span style="color: hsl(0, 100%, 40%);">-                  io 0x62 = 0x66</span><br><span style="color: hsl(0, 100%, 40%);">-                  io 0x64 = 0x1600</span><br><span style="color: hsl(0, 100%, 40%);">-                        io 0x66 = 0x1604</span><br><span style="color: hsl(0, 100%, 40%);">-                end</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-             register "config0" = "0xa6"</span><br><span style="color: hsl(0, 100%, 40%);">-         register "config1" = "0x05"</span><br><span style="color: hsl(0, 100%, 40%);">-         register "config2" = "0xa0"</span><br><span style="color: hsl(0, 100%, 40%);">-         register "config3" = "0x01"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-         register "beepmask0" = "0xfe"</span><br><span style="color: hsl(0, 100%, 40%);">-               register "beepmask1" = "0x96"</span><br><span style="color: hsl(0, 100%, 40%);">-               register "has_power_management_beeps" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-         register "event2_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event3_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event4_enable" = "0xf4"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event5_enable" = "0x3c"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event6_enable" = "0x80"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event7_enable" = "0x01"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event8_enable" = "0x01"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "event9_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "eventa_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "eventb_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "eventc_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-           register "eventd_enable" = "0xff"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-           register "has_bdc_detection" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">-          register "bdc_gpio_num" = "48"</span><br><span style="color: hsl(0, 100%, 40%);">-              register "bdc_gpio_lvl" = "0"</span><br><span style="color: hsl(0, 100%, 40%);">-       end</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  device cpu_cluster 0 on</span><br><span>              chip cpu/intel/model_2065x</span><br><span>                   device lapic 0 on end</span><br><span>@@ -159,6 +117,48 @@</span><br><span>                                 chip drivers/pc80/tpm</span><br><span>                                        device pnp 0c31.0 on end</span><br><span>                             end</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                         chip ec/lenovo/pmh7</span><br><span style="color: hsl(120, 100%, 40%);">+                                   device pnp ff.1 on # dummy</span><br><span style="color: hsl(120, 100%, 40%);">+                                    end</span><br><span style="color: hsl(120, 100%, 40%);">+                                   register "backlight_enable" = "0x01"</span><br><span style="color: hsl(120, 100%, 40%);">+                                      register "dock_event_enable" = "0x01"</span><br><span style="color: hsl(120, 100%, 40%);">+                             end</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                         chip ec/lenovo/h8</span><br><span style="color: hsl(120, 100%, 40%);">+                                     device pnp ff.2 on # dummy</span><br><span style="color: hsl(120, 100%, 40%);">+                                            io 0x60 = 0x62</span><br><span style="color: hsl(120, 100%, 40%);">+                                                io 0x62 = 0x66</span><br><span style="color: hsl(120, 100%, 40%);">+                                                io 0x64 = 0x1600</span><br><span style="color: hsl(120, 100%, 40%);">+                                              io 0x66 = 0x1604</span><br><span style="color: hsl(120, 100%, 40%);">+                                      end</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "config0" = "0xa6"</span><br><span style="color: hsl(120, 100%, 40%);">+                                       register "config1" = "0x05"</span><br><span style="color: hsl(120, 100%, 40%);">+                                       register "config2" = "0xa0"</span><br><span style="color: hsl(120, 100%, 40%);">+                                       register "config3" = "0x01"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                                     register "beepmask0" = "0xfe"</span><br><span style="color: hsl(120, 100%, 40%);">+                                     register "beepmask1" = "0x96"</span><br><span style="color: hsl(120, 100%, 40%);">+                                     register "has_power_management_beeps" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                                     register "event2_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event3_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event4_enable" = "0xf4"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event5_enable" = "0x3c"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event6_enable" = "0x80"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event7_enable" = "0x01"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event8_enable" = "0x01"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "event9_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "eventa_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "eventb_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "eventc_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+                                 register "eventd_enable" = "0xff"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                                       register "has_bdc_detection" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                                        register "bdc_gpio_num" = "48"</span><br><span style="color: hsl(120, 100%, 40%);">+                                    register "bdc_gpio_lvl" = "0"</span><br><span style="color: hsl(120, 100%, 40%);">+                             end</span><br><span>                  end</span><br><span>                  device pci 1f.2 on # IDE/SATA</span><br><span>                                subsystemid 0x17aa 0x2168</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27481">change 27481</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27481"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9ded7f639866d71d39ea0d5d0c36602d386c177f </div>
<div style="display:none"> Gerrit-Change-Number: 27481 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>