<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27478">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload/xhci: Check noop return code when debugging<br><br>We don't want to silently continue when the command ring is broken.<br><br>BUG=b:76831439<br>TEST=Verified on grunt<br><br>Change-Id: Ifa0b2fb087f5f0a36ba017a774fc98b33ab035a4<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M payloads/libpayload/drivers/usb/xhci.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27478/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c</span><br><span>index 2e70316..a3bf182 100644</span><br><span>--- a/payloads/libpayload/drivers/usb/xhci.c</span><br><span>+++ b/payloads/libpayload/drivers/usb/xhci.c</span><br><span>@@ -403,9 +403,12 @@</span><br><span>               xhci_post_command(xhci);</span><br><span> </span><br><span>                 /* Wait for result in event ring */</span><br><span style="color: hsl(0, 100%, 40%);">-             xhci_wait_for_command_done(xhci, cmd, 1);</span><br><span style="color: hsl(0, 100%, 40%);">-               xhci_debug("Command ring is %srunning\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                        (xhci->opreg->crcr_lo & CRCR_CRR) ? "" : "not ");</span><br><span style="color: hsl(120, 100%, 40%);">+            int cc = xhci_wait_for_command_done(xhci, cmd, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+          xhci_debug("Command ring is %srunning: cc: %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                      (xhci->opreg->crcr_lo & CRCR_CRR) ? "" : "not ", cc);</span><br><span style="color: hsl(120, 100%, 40%);">+                if (cc != CC_SUCCESS)</span><br><span style="color: hsl(120, 100%, 40%);">+                 fatal("noop command failed.\n");</span><br><span>   }</span><br><span> #endif</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27478">change 27478</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27478"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifa0b2fb087f5f0a36ba017a774fc98b33ab035a4 </div>
<div style="display:none"> Gerrit-Change-Number: 27478 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>