<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27452">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cavium/bdk: Fix coverity and remove hardcoded DRAM speed<br><br>* Fix CID1393963 (Uninitialized variables)<br>* Comment in working code<br>* Remove workaround to limit DDR speed<br><br>Change-Id: I96289da43c1018c2fdf9d013ce7f21d7511ba595<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c<br>M src/vendorcode/cavium/bdk/libdram/dram-spd.c<br>2 files changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/27452/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c b/src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c</span><br><span>index 7bc04ce..8775886 100644</span><br><span>--- a/src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c</span><br><span>+++ b/src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c</span><br><span>@@ -90,7 +90,6 @@</span><br><span> {"MULTI-NODE", "0"},</span><br><span> {"QLM-AUTO-CONFIG", "0"},</span><br><span> {"QLM-DIP-AUTO-CONFIG", "1"},</span><br><span style="color: hsl(0, 100%, 40%);">-{"DDR-SPEED.N0", "1333"},</span><br><span> {"DDR-CONFIG-SPD-ADDR.DIMM0.LMC0", "0x1050"},</span><br><span> {"USB-PWR-GPIO.N0.PORT0", "12"},</span><br><span> {"USB-PWR-GPIO-POLARITY.N0.PORT0", "0"},</span><br><span>diff --git a/src/vendorcode/cavium/bdk/libdram/dram-spd.c b/src/vendorcode/cavium/bdk/libdram/dram-spd.c</span><br><span>index 6498b85..329ae98 100644</span><br><span>--- a/src/vendorcode/cavium/bdk/libdram/dram-spd.c</span><br><span>+++ b/src/vendorcode/cavium/bdk/libdram/dram-spd.c</span><br><span>@@ -549,15 +549,17 @@</span><br><span>     int dimm_speed[8], dimm_count = 0;</span><br><span>     int dimms_per_lmc = 0;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    memset (dimm_speed, 0, sizeof(dimm_speed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     for (lmc = 0; lmc < 4; lmc++) {</span><br><span>         for (dimm = 0; dimm < DDR_CFG_T_MAX_DIMMS; dimm++) {</span><br><span>             const dimm_config_t *dimm_config = &ddr_config[lmc].dimm_config_table[dimm];</span><br><span style="color: hsl(0, 100%, 40%);">-            if (/*dimm_config->spd_addr ||*/ dimm_config->spd_ptr)</span><br><span style="color: hsl(120, 100%, 40%);">+            if (dimm_config->spd_addr || dimm_config->spd_ptr)</span><br><span>             {</span><br><span>                 speed = (ddr_type == DDR4_DRAM)</span><br><span>                     ? get_ddr4_spd_speed(node, dimm_config)</span><br><span>                     : get_ddr3_spd_speed(node, dimm_config);</span><br><span style="color: hsl(0, 100%, 40%);">-                //printf("N%d.LMC%d.DIMM%d: SPD speed %d\n", node, lmc, dimm, speed);</span><br><span style="color: hsl(120, 100%, 40%);">+                printf("N%d.LMC%d.DIMM%d: SPD speed %d\n", node, lmc, dimm, speed);</span><br><span>                 dimm_speed[dimm_count] = speed;</span><br><span>                 dimm_count++;</span><br><span>                 if (lmc == 0)</span><br><span>@@ -596,6 +598,6 @@</span><br><span>     ret_speed = mts_to_hertz(speed);</span><br><span> </span><br><span>  finish_up:</span><br><span style="color: hsl(0, 100%, 40%);">-    //printf("N%d: Returning default SPD speed %d\n", node, ret_speed);</span><br><span style="color: hsl(120, 100%, 40%);">+    printf("N%d: Returning default SPD speed %d\n", node, ret_speed);</span><br><span>     return ret_speed;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27452">change 27452</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27452"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I96289da43c1018c2fdf9d013ce7f21d7511ba595 </div>
<div style="display:none"> Gerrit-Change-Number: 27452 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>