<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/27433">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/nocturne/gpio.c">File src/mainboard/google/poppy/variants/nocturne/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/nocturne/gpio.c@181">Patch Set #2, Line 181:</a> <code style="font-family:monospace,monospace">PAD_CFG_NC(GPP_D8),</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">There's a a fix going into EVT2 firmware that is needed for EVT2 to fix a hang bug, but that same fi […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Okay, let's go with 1) then, which is this CL.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27433">change 27433</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27433"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e </div>
<div style="display:none"> Gerrit-Change-Number: 27433 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Ricky Liang <jcliang@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ricky Liang <jcliang@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Tomasz Figa <tfiga@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Jul 2018 04:31:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>